Skip to content

feat(v2/column): support groupField/stackField options #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

lessmost
Copy link
Member

按照之前的讨论:

  • 增加 isGroup 配置,和 isStack 配置并存,用户需要显示地指定 isGroup 或者 isStack

  • 增加 groupField/stackField/seriesField 配置,在 isGroup 为 true 时,groupField/seriesField/colorField 配置一样,配置一个就可以;在 isStack 为 true 时,stackField/seriesField/colorField 同样互为别名

柱形图剩余:

  • v1 中的 column-auto 系列的数据标签布局方法方法落入 G2

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 31, 2020
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

readonly isStack?: boolean;
/** 堆积拆分字段 */
readonly stackField?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit 四个字段感觉还是有点崩溃。先通过了,在发版本前再讨论!

@hustcc hustcc merged commit b0f2a4b into v2 Jul 31, 2020
@hustcc hustcc deleted the feat-column-options branch July 31, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants