feat(v2/column): 添加基础柱形图 #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hustcc merged 5 commits into v2 from feat-column

Jul 22, 2020

Member

lessmost commented Jul 21, 2020

No description provided.


          feat(v2/column): add column plot

07f2c6e

auto-add-label bot added the enhancement label

pr-triage bot added the PR: unreviewed label

tests-checker bot suggested changes

View reviewed changes

tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels

lessmost requested review from hustcc, visiky and BBSQQ

July 21, 2020 12:56

hustcc reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/column/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/column/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/column/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/column/types.ts Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/column/adaptor.ts Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

src/plots/column/types.ts Show resolved Hide resolved

hustcc added this to the v2 milestone


          feat(v2/column): export ColumnOptions & add findGeometry helper

c48d535

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels

lgtm-com bot commented Jul 22, 2020

This pull request introduces 1 alert when merging c48d535 into 8214a0c - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

visiky reviewed

View reviewed changes

__tests__/unit/plots/column/label-spec.ts Show resolved Hide resolved

src/plots/column/adaptor.ts Show resolved Hide resolved


          feat(v2/column): add label formatter unit test

3ffc91f

lgtm-com bot commented Jul 22, 2020

This pull request introduces 1 alert when merging 3ffc91f into 8214a0c - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class


          feat(v2/column): simplify findGeometry signature

5b90c6b

hustcc reviewed

View reviewed changes

src/common/helper.ts

+              /**
+               * 在 Chart 中查找第一个指定 type 类型的 geometry
+               * @param chart

Member

hustcc Jul 22, 2020

type 的 param 没有写


          feat(v2/column): changes with cr

309f361

lgtm-com bot commented Jul 22, 2020

This pull request introduces 1 alert when merging 309f361 into 8214a0c - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

hustcc self-requested a review

July 22, 2020 03:44

hustcc approved these changes

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels

hustcc merged commit 62683d5 into v2

hustcc deleted the feat-column branch

July 22, 2020 03:45

pr-triage bot added PR: merged and removed PR: partially-approved labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PR: merged