Skip to content

feat(pie-annotation): add pie options #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 20, 2020
Merged

feat(pie-annotation): add pie options #1301

merged 7 commits into from
Jul 20, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Jul 18, 2020 •
edited
Loading

  1. add annotations
  2. add quick annotation: statistic in the center
  3. add statistic interaction

饼图 基础

  • tooltip
  • style
  • label
  • annotation
  • interaction

饼图 增强

  • variable label types, label percent
  • statistic annotation (中心文本 指标卡)
  • animate
  • tooltip enterable

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 18, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 18, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@visiky visiky requested review from hustcc and lxfu1 July 18, 2020 11:26
@visiky visiky added the v2 label Jul 18, 2020
@visiky visiky added this to the v2 milestone Jul 18, 2020
@visiky visiky self-assigned this Jul 18, 2020
@visiky visiky marked this pull request as draft July 18, 2020 15:23
@visiky visiky force-pushed the feat/pie-annotation branch from 49d6b4a to a7e2070 Compare July 19, 2020 03:21
@visiky visiky removed the PR: draft label Jul 19, 2020
@visiky visiky marked this pull request as ready for review July 19, 2020 05:56
xinming added 4 commits July 19, 2020 14:03
feat(pie-annotation): add pie options
ff30b9f 
    1. add annotations
    2. add quick annotation: statistic in the center
    3. add statistic interaction
feat(v2/pie-annotations): annotations 更新时，需要先clear
c4fdd1f
feat(v2/pie-annotations): update statistic config & add testcases
3e890f9 
1. 修改 statistic formatter 参数, 第一个参数是指标统计数据，第二是原始数据
2. 增加 interactions 测试用例
feat(v2/pie-annotations): 增加 utils 测试单例
7f9d4a0
@visiky visiky force-pushed the feat/pie-annotation branch from f689f44 to 7f9d4a0 Compare July 19, 2020 06:05
visiky
visiky commented Jul 19, 2020
View reviewed changes
hustcc
hustcc reviewed Jul 20, 2020
View reviewed changes
hustcc
hustcc reviewed Jul 20, 2020
View reviewed changes
hustcc
hustcc reviewed Jul 20, 2020
View reviewed changes
@hustcc hustcc merged commit f9b9acf into v2 Jul 20, 2020
@hustcc hustcc deleted the feat/pie-annotation branch July 20, 2020 02:54
@visiky visiky linked an issue Jul 22, 2020 that may be closed by this pull request
环图bug #1270
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees

@visiky visiky

Labels
enhancement New feature or request PR: merged v2
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

环图bug
2 participants
@visiky @hustcc