Skip to content

feat(pie/label): add pie options #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2020
Merged

feat(pie/label): add pie options #1296

merged 1 commit into from
Jul 19, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Jul 15, 2020 •
edited
Loading

饼图 基础

  • tooltip
  • style
  • label

饼图 增强

  • variable label types, label percent
  • annotation (中心文本)
  • animate
  • interaction
  • tooltip enterable

@visiky visiky added enhancement New feature or request v2 labels Jul 15, 2020
@visiky visiky requested review from hustcc and lxfu1 July 15, 2020 15:21
tests-checker[bot]
tests-checker bot suggested changes Jul 15, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@visiky visiky changed the title feat(pie/label): 适配pie label配置到G2 label配置 feat(pie/label): add pie options Jul 15, 2020
@hustcc hustcc added this to the v2 milestone Jul 16, 2020
hustcc
hustcc reviewed Jul 16, 2020
View reviewed changes
hustcc
hustcc reviewed Jul 16, 2020
View reviewed changes
@hustcc hustcc self-requested a review July 18, 2020 10:26
@visiky visiky merged commit cd3be27 into v2 Jul 19, 2020
@visiky visiky deleted the pie-label branch July 19, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged v2
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
2 participants
@visiky @hustcc