Skip to content

feat(flow): adaptor 使用 flow 的方式处理,让逻辑散开且容易复用 #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

feat(flow): adaptor 使用 flow 的方式处理,让逻辑散开且容易复用 #1285

merged 1 commit into from
Jul 14, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Jul 14, 2020

  • adaptor 改成纯函数
  • 使用 flow 的方式处理 options

@hustcc hustcc requested review from lessmost and visiky July 14, 2020 03:16
@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 14, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 14, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@hustcc hustcc merged commit ec33cd6 into v2 Jul 14, 2020
@hustcc hustcc deleted the feat-flow branch July 14, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@lessmost lessmost lessmost approved these changes

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustcc @lessmost @visiky