Skip to content

fix(Liquid): should render wave only when percent > 0 #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix(Liquid): should render wave only when percent > 0 #3455

merged 1 commit into from
Feb 6, 2023

Conversation

dengfuping
Copy link
Member

PR includes

  • percent 大于 0 时才绘制水波，避免为 0 时仍然能看到波峰，容易误导用户。
  • add / modify test cases
  • documents, demos

Screenshot

Before After
image image
image image

@github-actions github-actions bot added the bugfix label Feb 1, 2023
@visiky visiky merged commit 6fb1e4d into antvis:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
bugfix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dengfuping @visiky