Skip to content

feat(sunburst): 旭日图支持图例配置 & 单测 #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2021
Merged

feat(sunburst): 旭日图支持图例配置 & 单测 #3011

merged 2 commits into from
Dec 8, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Dec 8, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@visiky visiky requested a review from pearmini December 8, 2021 01:34
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021 •
edited
Loading

😭 Deploy PR Preview 4e77880 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Dec 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1553043791

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 95.234%
Files with Coverage Reduction New Missed Lines %
src/plots/sunburst/adaptor.ts 1 93.0%
Totals Coverage Status
Change from base Build 1514781146: -0.002%
Covered Lines: 6828
Relevant Lines: 6970
💛 - Coveralls

@visiky visiky merged commit 5d65033 into master Dec 8, 2021
@visiky visiky deleted the sunburst-legend branch December 8, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@pearmini pearmini Awaiting requested review from pearmini

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc