Skip to content

Commit 4be91f9

Browse files
authored
fix(sankey): close sankey node tooltip (#2072)
* fix(sankey): close sankey node tooltip * fix(sankey): 修复 tooltip: false 无法生效
1 parent 290fb5a commit 4be91f9

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

__tests__/bugs/issue-2015-spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('issue 2015', () => {
3333
tooltip: false,
3434
});
3535
// @ts-ignore
36-
expect(scatter.chart.geometries[0].tooltipOption).toBeUndefined();
36+
expect(scatter.chart.geometries[0].tooltipOption).toBe(false);
3737
scatter.destroy();
3838
});
3939
});

__tests__/unit/plots/scatter/tooltip-spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ describe('scatter', () => {
4444
tooltip: false,
4545
});
4646
expect(scatter.chart.getOptions().tooltip).toBe(false);
47-
expect(scatter.chart.geometries[0].tooltipOption).toBeUndefined();
47+
expect(scatter.chart.geometries[0].tooltipOption).toBe(false);
4848
expect(scatter.chart.getComponents().find((co) => co.type === 'tooltip')).toBe(undefined);
4949

50-
scatter.destroy();
50+
// scatter.destroy();
5151
});
5252

5353
it('tooltip: itemTpl options', () => {

__tests__/unit/utils/tooltip-spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { getTooltipMapping } from '../../../src/utils/tooltip';
22

33
describe('util tooltip', () => {
44
it('getTooltipMapping', () => {
5-
expect(getTooltipMapping(false, [])).toEqual({});
5+
expect(getTooltipMapping(false, [])).toEqual({ fields: false });
66

77
expect(getTooltipMapping({}, ['x'])).toEqual({});
88

src/types/tooltip.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { TooltipAttr } from '../types/attr';
33

44
export type TooltipMapping = {
55
/** 指定需要显示 tooltip 中的字段,默认是包含 x seriesFields y */
6-
readonly fields?: string[];
6+
readonly fields?: string[] | false;
77
/** value 格式化 **/
88
readonly formatter?: TooltipAttr;
99
};

src/utils/tooltip.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ import { Tooltip, TooltipMapping } from '../types/tooltip';
88
*/
99
export function getTooltipMapping(tooltip: Tooltip, defaultFields: string[]): TooltipMapping {
1010
if (tooltip === false) {
11-
return {};
11+
return {
12+
fields: false, // 关闭 tooltip
13+
};
1214
}
1315

1416
let fields = get(tooltip, 'fields');

0 commit comments

Comments
 (0)