antctl Support Bundle Should Collect Logs from Crashed Agent and Controller Containers

[edwardbadboy]

Describe the bug

When antctl runs in remote mode, it needs to connect to remote agent or controller APIServer to get support bundle. If remote agent or controller fails, antctl writes the failed node name in support bundle. I'd like to suggest an improvement. If antctl fails to connect to agent/controller APIServer, it can alternatively get logs from K8s API. For example:

logOption := &v1.PodLogOptions{Container: containerName, SinceSeconds: ...}
logs := k8sClientset.CoreV1().Pods("kube-system").GetLogs(podName, logOption)
logStream, err := logs.Stream(context.TODO())
...

Another improvement is that support bundle function controllerRemoteRunE should run getClusterInfo even if there is failure in previous steps. This is to deal with a corner case (or maybe we can see it as a user error) that incompatible antctl is used to get agent and controller logs, then antctl may fail in creating clients for AntreaAgentInfo and AntreaControllerInfo, and it collects nothing. If in this case it can at least run getClusterInfo, we will be able to see the Antrea version from collected Pod manifests and get a clue.

These improvements are minor, but they'll help to save some communication round-trips.

To Reproduce
Edit antrea-controller Deployment and change antrea-controller command to "false".

$ antctl supportbundle --controller-only -d test-bundle
Controller Info Failed Reason: Post "https://10.10.10.10:10349/apis/system.antrea.io/v1beta1/supportbundles": dial tcp 10.176.26.253:10349: connect: connection refused
Finish [--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 200ms
Error: no data was collected: Post "https://10.10.10.10:10349/apis/system.antrea.io/v1beta1/supportbundles": dial tcp 10.176.26.253:10349: connect: connection refused;

Expected
It's better to also request log stream from K8s API.

Actual behavior
antctl only reports an error.

Versions:
Please provide the following information:

• Antrea version: v1.5.2, v1.6.0

[hangyan]

working on this

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days