update

Signed-off-by: Hang Yan <[email protected]>

Author: hangyan

pkg/antctl/antctl.go

@@ -779,7 +779,7 @@ $ antctl get podmulticaststats pod -n namespace`,
 		},
 		{
 			cobraCommand:      packetcapture.Command,
-			supportAgent:      false,
+			supportAgent:      true,
 			supportController: true,
 		},
 		{

pkg/antctl/command_list.go

@@ -139,9 +139,11 @@ func (cl *commandList) GetDebugCommands(mode string) [][]string {
 		}
 	}
 	for _, cmd := range cl.rawCommands {
-		if cmd.cobraCommand.Use == "proxy" {
+
+		if cmd.cobraCommand.Use == "proxy" || cmd.cobraCommand.Use == "packetcapture" {
 			// proxy will keep running until interrupted so it
-			// cannot be used as is in e2e tests.
+			// cannot be used as is in e2e tests. For packetcapture, the default values didn't
+			// make much sense in e2e tests.
 			continue
 		}
 		if mode == runtime.ModeController && cmd.supportController ||

pkg/antctl/raw/packetcapture/command.go

@@ -84,7 +84,7 @@ func init() {
 
 	Command.Flags().StringVarP(&options.source, "source", "S", "", "source of the the PacketCapture: Namespace/Pod, Pod, or IP")
 	Command.Flags().StringVarP(&options.dest, "destination", "D", "", "destination of the PacketCapture: Namespace/Pod, Pod, or IP")
-	Command.Flags().Int32VarP(&options.number, "number", "n", 0, "target number of packets to capture, the capture will stop when it is reached")
+	Command.Flags().Int32VarP(&options.number, "number", "n", 1, "target number of packets to capture, the capture will stop when it is reached")
 	Command.Flags().StringVarP(&options.flow, "flow", "f", "", "specify the flow (packet headers) of the PacketCapture, including tcp_src, tcp_dst, udp_src, udp_dst")
 	Command.Flags().BoolVarP(&options.nowait, "nowait", "", false, "if set, command returns without retrieving results")
 	Command.Flags().StringVarP(&options.outputDir, "output-dir", "o", ".", "save the packets file to the target directory")