Skip to content

Commit 3dd0cb4

Browse files
committed
review changes part1
1 parent 81302b1 commit 3dd0cb4

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def mke_app_reset(request):
177177
_CHECK_PROCESS_RETURN_CODE = os.name == "nt"
178178

179179
# set to true if you want to see all the subprocess stdout/stderr
180-
_PRINT_SUBPROCESS_OUTPUT_TO_CONSOLE = False
180+
_PRINT_SUBPROCESS_OUTPUT_TO_CONSOLE = True
181181

182182

183183
@pytest.fixture()

tests/embedding/test_app.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ def test_normal_appdata(pytestconfig, run_subprocess, rootdir):
263263

264264

265265
@pytest.mark.embedding_scripts
266-
@pytest.mark.python_env
267266
def test_building_gallery(pytestconfig, run_subprocess, rootdir):
268267
"""Test for building gallery check.
269268
@@ -284,7 +283,7 @@ def test_building_gallery(pytestconfig, run_subprocess, rootdir):
284283
stdout, _ = run_subprocess([sys.executable, embedded_gallery_py, version, "True"])
285284
stdout = stdout.decode()
286285

287-
# Assert Exception
286+
# Assert stdout afte launching multiple app
288287
assert "Multiple App launched with building gallery flag on" in stdout
289288

290289

tests/scripts/build_gallery_test.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,9 @@ def launch_app(version):
4343

4444
pymechanical.BUILDING_GALLERY = True
4545

46-
try:
47-
app2 = launch_app(version)
48-
app3 = launch_app(version)
49-
print("Multiple App launched with building gallery flag on")
50-
except Exception as e:
51-
print(e)
46+
app2 = launch_app(version)
47+
app3 = launch_app(version)
48+
print("Multiple App launched with building gallery flag on")
5249

5350
elif build_gallery_flag == "False":
5451
try:

0 commit comments

Comments
 (0)