CHORE: Remove support of version 23R2 (#1255)

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: dipinknair

doc/changelog.d/1255.maintenance.md

@@ -0,0 +1 @@
+Remove support of version 23r2

src/ansys/mechanical/core/embedding/app.py

@@ -26,7 +26,6 @@
 import atexit
 import os
 from pathlib import Path
-import shutil
 import typing
 
 from ansys.mechanical.core import LOG
@@ -84,12 +83,8 @@ def _start_application(configuration: AddinConfiguration, version, db_file) -> "
         os.environ["ANSYS_MECHANICAL_STANDALONE_NO_ACT_EXTENSIONS"] = "1"
 
     addin_configuration_name = configuration.addin_configuration
-    # Starting with version 241 we can pass a configuration name to the constructor
-    # of Application
-    if int(version) >= 241:
-        return Ansys.Mechanical.Embedding.Application(db_file, addin_configuration_name)
-    else:
-        return Ansys.Mechanical.Embedding.Application(db_file)
+
+    return Ansys.Mechanical.Embedding.Application(db_file, addin_configuration_name)
 
 
 def is_initialized():
@@ -325,11 +320,6 @@ def save_as(self, path: str, overwrite: bool = False, remove_lock: bool = False)
         ------
         Exception
             If the file already exists at the specified path and `overwrite` is False.
-
-        Notes
-        -----
-        For version 232, if `overwrite` is True, the existing file and its associated directory
-        (if any) will be removed before saving the new file.
         """
         if not os.path.exists(path):
             self.DataModel.Project.SaveAs(path)
@@ -340,39 +330,28 @@ def save_as(self, path: str, overwrite: bool = False, remove_lock: bool = False)
                 f"File already exists in {path}, Use ``overwrite`` flag to "
                 "replace the existing file."
             )
-        if self.version < 241:  # pragma: no cover
-            file_name = os.path.basename(path)
-            file_dir = os.path.dirname(path)
-            associated_dir = os.path.join(file_dir, os.path.splitext(file_name)[0] + "_Mech_Files")
-
-            # Remove existing files and associated folder
-            os.remove(path)
-            if os.path.exists(associated_dir):
-                shutil.rmtree(associated_dir)
-            # Save the new file
-            self.DataModel.Project.SaveAs(path)
-        else:
-            if remove_lock:
-                file_path = Path(path)
-                associated_dir = file_path.parent / f"{file_path.stem}_Mech_Files"
-                lock_file = associated_dir / ".mech_lock"
-                # Remove the lock file if it exists before saving the project file
-                if lock_file.exists():
-                    self.log_warning(f"Removing the lock file, {lock_file}... ")
-                    lock_file.unlink()
-            try:
-                self.DataModel.Project.SaveAs(path, overwrite)
-            except Exception as e:
-                error_msg = str(e)
-                if "The project is locked by" in error_msg:
-                    self.log_error(
-                        f"Failed to save project as {path}: {error_msg}\n"
-                        "Hint: The project file is locked. "
-                        "Try using the 'remove_lock=True' option when saving the project."
-                    )
-                else:
-                    self.log_error(f"Failed to save project as {path}: {error_msg}")
-                raise e
+
+        if remove_lock:
+            file_path = Path(path)
+            associated_dir = file_path.parent / f"{file_path.stem}_Mech_Files"
+            lock_file = associated_dir / ".mech_lock"
+            # Remove the lock file if it exists before saving the project file
+            if lock_file.exists():
+                self.log_warning(f"Removing the lock file, {lock_file}... ")
+                lock_file.unlink()
+        try:
+            self.DataModel.Project.SaveAs(path, overwrite)
+        except Exception as e:
+            error_msg = str(e)
+            if "The project is locked by" in error_msg:
+                self.log_error(
+                    f"Failed to save project as {path}: {error_msg}\n"
+                    "Hint: The project file is locked. "
+                    "Try using the 'remove_lock=True' option when saving the project."
+                )
+            else:
+                self.log_error(f"Failed to save project as {path}: {error_msg}")
+            raise e
 
     def launch_gui(self, delete_tmp_on_close: bool = True, dry_run: bool = False):
         """Launch the GUI."""
@@ -391,10 +370,7 @@ def close(self):
     def exit(self):
         """Exit the application."""
         self._unsubscribe()
-        if self.version < 241:
-            self.ExtAPI.Application.Close()
-        else:
-            self.ExtAPI.Application.Exit()
+        self.ExtAPI.Application.Exit()
 
     def execute_script(self, script: str) -> typing.Any:
         """Execute the given script with the internal IronPython engine."""

src/ansys/mechanical/core/embedding/mechanical_warnings.py

@@ -63,15 +63,9 @@ def _on_obsolete_message(sender: typing.Any, args: typing.Any):
 
 def connect_warnings(app: "ansys.mechanical.core.embedding.app.App"):
     """Connect Mechanical warnings to the `warnings` Python module."""
-    if int(app.version) < 241:
-        return
-
     app._app.OnObsoleteMessage += _on_obsolete_message
 
 
 def disconnect_warnings(app):
     """Disconnect Mechanical warnings from the `warnings` Python module."""
-    if int(app.version) < 241:
-        return
-
     app._app.OnObsoleteMessage -= _on_obsolete_message

src/ansys/mechanical/core/run.py

@@ -27,7 +27,6 @@
 import os
 import sys
 import typing
-import warnings
 
 import ansys.tools.path as atp
 import click
@@ -130,10 +129,6 @@ def _cli_impl(
     if (not graphical) or (not show_welcome_screen):
         args.append("-AppModeMech")
 
-    if version < 232:
-        args.append("-nosplash")
-        args.append("-notabctrl")
-
     if not graphical:
         args.append("-b")
 
@@ -159,14 +154,8 @@ def _cli_impl(
 
     if (not graphical) and input_script:
         exit = True
-        if version < 241:
-            warnings.warn(
-                "Please ensure ExtAPI.Application.Close() is at the end of your script. "
-                "Without this command, Batch mode will not terminate.",
-                stacklevel=2,
-            )
 
-    if exit and input_script and version >= 241:
+    if exit and input_script:
         args.append("-x")
 
     profile: UniqueUserProfile = None

tests/embedding/test_app.py

@@ -33,6 +33,7 @@
 
 from ansys.mechanical.core.embedding.app import is_initialized
 from ansys.mechanical.core.embedding.cleanup_gui import cleanup_gui
+from ansys.mechanical.core.embedding.initializer import SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS
 from ansys.mechanical.core.embedding.ui import _launch_ui
 import ansys.mechanical.core.embedding.utils as utils
 
@@ -47,7 +48,6 @@ def test_app_repr(embedded_app):
 
 
 @pytest.mark.embedding
-@pytest.mark.minimum_version(241)
 def test_deprecation_warning(embedded_app):
     harmonic_acoustic = embedded_app.Model.AddHarmonicAcousticAnalysis()
     with pytest.warns(UserWarning):
@@ -118,7 +118,7 @@ def test_app_version(embedded_app):
     """Test version of the Application class."""
     version = embedded_app.version
     assert type(version) is int
-    assert version >= 241
+    assert version >= min(SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS)
 
 
 @pytest.mark.embedding

tests/embedding/test_logger.py

@@ -117,7 +117,6 @@ def test_logging_write_info_after_initialize_with_error_level(
 @pytest.mark.parametrize("addin_configuration", ["Mechanical", "WorkBench"])
 @pytest.mark.embedding_scripts
 @pytest.mark.embedding_logging
-@pytest.mark.minimum_version(241)
 def test_addin_configuration(rootdir, run_subprocess, pytestconfig, addin_configuration):
     """Test that mechanical can start with both the Mechanical and WorkBench configuration."""
     stderr = _run_embedding_log_test(

tests/test_cli.py

@@ -29,6 +29,7 @@
 from click.testing import CliRunner
 import pytest
 
+from ansys.mechanical.core.embedding.initializer import SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS
 from ansys.mechanical.core.ide_config import cli as ideconfig_cli
 from ansys.mechanical.core.ide_config import get_stubs_location, get_stubs_versions
 from ansys.mechanical.core.run import _cli_impl
@@ -104,13 +105,6 @@ def test_cli_appmode(disable_cli, pytestconfig):
     assert "-AppModeMech" not in args
 
 
-@pytest.mark.cli
-def test_cli_231(disable_cli):
-    args, _ = _cli_impl(exe="AnsysWBU.exe", version=231, port=11)
-    assert "-nosplash" in args
-    assert "-notabctrl" in args
-
-
 @pytest.mark.cli
 def test_cli_port(disable_cli, pytestconfig):
     version = int(pytestconfig.getoption("ansys_version"))
@@ -216,18 +210,10 @@ def test_cli_features(disable_cli, pytestconfig):
 @pytest.mark.cli
 def test_cli_exit(disable_cli, pytestconfig):
     version = int(pytestconfig.getoption("ansys_version"))
-    # Regardless of version, `exit` does nothing on its own
-    args, _ = _cli_impl(exe="AnsysWBU.exe", version=232, exit=True, port=11)
-    assert "-x" not in args
 
     args, _ = _cli_impl(exe="AnsysWBU.exe", version=version, exit=True, port=11)
     assert "-x" not in args
 
-    # On versions earlier than 2024R1, `exit` throws a warning but does nothing
-    with pytest.warns(UserWarning):
-        args, _ = _cli_impl(exe="AnsysWBU.exe", version=232, exit=True, input_script="foo.py")
-        assert "-x" not in args
-
     # In UI mode, exit must be manually specified
     args, _ = _cli_impl(exe="AnsysWBU.exe", version=version, input_script="foo.py", graphical=True)
     assert "-x" not in args
@@ -247,25 +233,31 @@ def test_cli_exit(disable_cli, pytestconfig):
 
 @pytest.mark.cli
 def test_cli_batch_required_args(disable_cli):
-    # ansys-mechanical -r 241 => exception
+    # ansys-mechanical -r <version> => exception
     with pytest.raises(Exception):
-        _cli_impl(exe="AnsysWBU.exe", version=241)
+        _cli_impl(exe="AnsysWBU.exe", version=max(SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS))
 
-    # ansys-mechanical -r 241 -g => no exception
+    # ansys-mechanical -r <version> -g => no exception
     try:
-        _cli_impl(exe="AnsysWBU.exe", version=241, graphical=True)
+        _cli_impl(
+            exe="AnsysWBU.exe", version=max(SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS), graphical=True
+        )
     except Exception as e:
         assert False, f"cli raised an exception: {e}"
 
-    # ansys-mechanical -r 241 -i input.py => no exception
+    # ansys-mechanical -r <version> -i input.py => no exception
     try:
-        _cli_impl(exe="AnsysWBU.exe", version=241, input_script="input.py")
+        _cli_impl(
+            exe="AnsysWBU.exe",
+            version=max(SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS),
+            input_script="input.py",
+        )
     except Exception as e:
         assert False, f"cli raised an exception: {e}"
 
-    # ansys-mechanical -r 241 -port 11 => no exception
+    # ansys-mechanical -r <version> -port 11 => no exception
     try:
-        _cli_impl(exe="AnsysWBU.exe", version=241, port=11)
+        _cli_impl(exe="AnsysWBU.exe", version=max(SUPPORTED_MECHANICAL_EMBEDDING_VERSIONS), port=11)
     except Exception as e:
         assert False, f"cli raised an exception: {e}"
 

tests/test_mechanical.py

@@ -410,7 +410,7 @@ def test_find_mechanical_path():
         else:
             assert ".workbench" in path
 
-        assert re.match(r"\d{3}", str(version)) and version >= 232
+        assert re.match(r"\d{3}", str(version)) and version >= 241
 
 
 @pytest.mark.remote_session_launch