Removing temporary files at the end of execution (#1784)

* Removing temporary files at the end of execution

* fix edge cdread case

* Fix mpread tests

Author: germa89

src/ansys/mapdl/core/mapdl.py

@@ -3006,6 +3006,8 @@ def load_array(self, name, array):
 
         if self._local:
             os.remove(filename)
+        else:
+            self.slashdelete(filename)
 
     def load_table(self, name, array, var1="", var2="", var3="", csysid=""):
         """Load a table from Python to into MAPDL.
@@ -3128,6 +3130,11 @@ def load_table(self, name, array, var1="", var2="", var3="", csysid=""):
         # skip the first line its a header we wrote in np.savetxt
         self.tread(name, filename, nskip=1, mute=True)
 
+        if self._local:
+            os.remove(filename)
+        else:
+            self.slashdelete(filename)
+
     def _display_plot(self, *args, **kwargs):  # pragma: no cover
         raise NotImplementedError("Implemented by child class")
 

src/ansys/mapdl/core/mapdl_grpc.py

@@ -1218,8 +1218,12 @@ def sys(self, cmd):
         super().sys(f"{cmd} > {tmp_file}")
         if self._local:  # no need to download when local
             with open(os.path.join(self.directory, tmp_file)) as fobj:
-                return fobj.read()
-        return self._download_as_raw(tmp_file).decode()
+                obj = fobj.read()
+        else:
+            obj = self._download_as_raw(tmp_file).decode()
+
+        self.slashdelete(tmp_file)
+        return obj
 
     def download_result(self, path=None, progress_bar=False, preference=None):
         """Download remote result files to a local directory
@@ -1559,9 +1563,12 @@ def input(
             # Using CDREAD
             option = kwargs.get("cd_read_option", "COMB")
             tmp_dat = f"/OUT,{tmp_out}\n{orig_cmd},'{option}','{filename}'\n"
+            delete_uploaded_files = False
+
         else:
             # Using default INPUT
             tmp_dat = f"/OUT,{tmp_out}\n{orig_cmd},'{filename}'\n"
+            delete_uploaded_files = True
 
         if write_to_log and self._apdl_log is not None:
             if not self._apdl_log.closed:
@@ -1605,6 +1612,8 @@ def input(
             # Deleting the previous files
             self.slashdelete(tmp_name)
             self.slashdelete(tmp_out)
+            if filename in self.list_files() and delete_uploaded_files:
+                self.slashdelete(filename)
 
         return output
 

tests/test_mapdl.py

@@ -1416,13 +1416,13 @@ def test_mpfunctions(mapdl, cube_solve, capsys):
     assert "PROPERTY TEMPERATURE TABLE    NUM. TEMPS=  1" in output
     assert "TEMPERATURE TABLE ERASED." in output
     assert "0.4000000" in output
-    assert fname_ in mapdl.list_files()
     # check if materials are read into the db
     assert mapdl.get_value("NUXY", "1", "TEMP", 0) == nuxy
     assert np.allclose(mapdl.get_value("EX", 1, "TEMP", 0), ex)
 
     # Reding file in remote
     fname_ = f"{fname}.{ext}"
+    mapdl.upload(fname_)
     os.remove(fname_)
     assert not os.path.exists(fname_)
     assert f"{fname}.{ext}" in mapdl.list_files()