test #114

Author: svandenb-dev

src/pyedb/grpc/database/primitive/padstack_instances.py

@@ -419,11 +419,13 @@ def position(self, value):
         pos = []
         for v in value:
             if isinstance(v, (float, int, str)):
-                pos.append(GrpcValue(v))
+                pos.append(GrpcValue(v, self._pedb.active_cell))
             else:
                 pos.append(v)
         point_data = GrpcPointData(pos[0], pos[1])
-        self.set_position_and_rotation(point_data, GrpcValue(self.rotation))
+        self.set_position_and_rotation(
+            x=point_data.x, y=point_data.y, rotation=GrpcValue(self.rotation, self._pedb.active_cell)
+        )
 
     @property
     def rotation(self):

src/pyedb/grpc/edb.py

@@ -3705,9 +3705,15 @@ def _apply_variable(orig_name, orig_value):
             var = self._clean_string_for_variable_name(var)
             if var not in self.variables:
                 if use_relative_variables:
-                    self.add_design_variable(var, 0.0)
+                    if var.startswith("$"):
+                        self.add_project_variable(var, 0.0)
+                    else:
+                        self.add_design_variable(var, 0.0)
                 else:
-                    self.add_design_variable(var, orig_value)
+                    if var.startswith("$"):
+                        self.add_project_variable(var, orig_value)
+                    else:
+                        self.add_design_variable(var, orig_value)
             if use_relative_variables:
                 return f"{orig_value}+{var}", var
             else:
@@ -3722,7 +3728,7 @@ def _apply_variable(orig_name, orig_value):
                 _layers = {k: v for k, v in self.stackup.layers.items() if k in layer_filter}
             for layer_name, layer in _layers.items():
                 var, val = _apply_variable(f"${layer_name}", layer.thickness)
-                layer.thickness = var
+                layer.thickness = GrpcValue(var, self.active_db)
                 parameters.append(val)
         if materials:
             if not material_filter:
@@ -3732,14 +3738,14 @@ def _apply_variable(orig_name, orig_value):
             for mat_name, material in _materials.items():
                 if material.conductivity < 1e4:
                     var, val = _apply_variable(f"$epsr_{mat_name}", material.permittivity)
-                    material.permittivity = var
+                    material.permittivity = GrpcValue(var, self.active_db)
                     parameters.append(val)
                     var, val = _apply_variable(f"$loss_tangent_{mat_name}", material.dielectric_loss_tangent)
-                    material.dielectric_loss_tangent = var
+                    material.dielectric_loss_tangent = GrpcValue(var, self.active_db)
                     parameters.append(val)
                 else:
                     var, val = _apply_variable(f"$sigma_{mat_name}", material.conductivity)
-                    material.conductivity = var
+                    material.conductivity = GrpcValue(var, self.active_db)
                     parameters.append(val)
         if traces:
             if not trace_net_filter:
@@ -3755,7 +3761,7 @@ def _apply_variable(orig_name, orig_value):
                 else:
                     trace_width_variable = f"{path.aedt_name}"
                 var, val = _apply_variable(trace_width_variable, path.width)
-                path.width = var
+                path.width = GrpcValue(var, self.active_cell)
                 parameters.append(val)
         if not padstack_definition_filter:
             if trace_net_filter:
@@ -3774,7 +3780,7 @@ def _apply_variable(orig_name, orig_value):
             padstack_defs = {k: v for k, v in self.padstacks.definitions.items() if k in padstack_definition_filter}
 
         for def_name, padstack_def in padstack_defs.items():
-            if not padstack_def.via_start_layer == padstack_def.via_stop_layer:
+            if not padstack_def.start_layer == padstack_def.stop_layer:
                 if via_holes:  # pragma no cover
                     if use_relative_variables:
                         hole_variable = "$hole_diameter"

tests/grpc/system/test_edb_nets.py

@@ -132,7 +132,7 @@ def test_nets_arc_data(self, edb_examples):
 
     @pytest.mark.slow
     def test_nets_dc_shorts(self, edb_examples):
-        # TODO check connected object does not return anything.
+        # TODO get_connected_object return empty list.
         edbapp = edb_examples.get_si_verse()
         dc_shorts = edbapp.layout_validation.dc_shorts()
         assert dc_shorts
@@ -157,21 +157,17 @@ def test_nets_eligible_power_nets(self, edb_examples):
 
     def test_nets_merge_polygon(self):
         """Convert paths from net into polygons."""
-        # TODO check bug #464 status
+        # Done
         source_path = os.path.join(local_path, "example_models", test_subfolder, "test_merge_polygon.aedb")
         target_path = os.path.join(self.local_scratch.path, "test_merge_polygon", "test.aedb")
         self.local_scratch.copyfolder(source_path, target_path)
         edbapp = Edb(target_path, desktop_version, restart_rpc_server=True)
         assert edbapp.nets.merge_nets_polygons(["net1", "net2"])
         edbapp.close_edb()
 
-    def test_layout_auto_parametrization_0(self):
+    def test_layout_auto_parametrization_0(self, edb_examples):
         # TODO fix parameters first
-        source_path = os.path.join(local_path, "example_models", test_subfolder, "ANSYS-HSD_V1.aedb")
-        target_path = os.path.join(self.local_scratch.path, "test_auto_parameters", "test.aedb")
-        output_path = os.path.join(self.local_scratch.path, "test_auto_parameters", "test_absolute.aedb")
-        self.local_scratch.copyfolder(source_path, target_path)
-        edbapp = Edb(target_path, desktop_version)
+        edbapp = edb_examples.get_si_verse()
         parameters = edbapp.auto_parametrize_design(
             layers=True,
             layer_filter="1_Top",
@@ -181,7 +177,6 @@ def test_layout_auto_parametrization_0(self):
             antipads=False,
             traces=False,
             use_relative_variables=False,
-            output_aedb_path=output_path,
             open_aedb_at_end=False,
         )
         assert "$1_Top_value" in parameters