test modeler #2

Author: svandenb-dev

src/pyedb/grpc/database/modeler.py

@@ -530,25 +530,25 @@ def _create_path(
 
         Parameters
         ----------
-        points : :class:`dotnet.database.layout.Shape`
+        points: .:class:`dotnet.database.layout.Shape`
             List of points.
         layer_name : str
             Name of the layer on which to create the path.
         width : float, optional
             Width of the path. The default is ``1``.
-        net_name : str, optional
+        net_name: str, optional
             Name of the net. The default is ``""``.
         start_cap_style : str, optional
             Style of the cap at its start. Options are ``"Round"``,
-            ``"Extended",`` and ``"Flat"``. The default is
-            ``"Round"``.
+            ``"Extended", `` and ``"Flat"``. The default is
+            ``"Round".
         end_cap_style : str, optional
             Style of the cap at its end. Options are ``"Round"``,
-            ``"Extended",`` and ``"Flat"``. The default is
-            ``"Round"``.
+            ``"Extended", `` and ``"Flat"``. The default is
+            ``"Round".
         corner_style : str, optional
             Style of the corner. Options are ``"Round"``,
-            ``"Sharp"`` and ``"Mitered"``. The default is ``"Round"``.
+            ``"Sharp"`` and ``"Mitered"``. The default is ``"Round".
 
         Returns
         -------
@@ -574,12 +574,23 @@ def _create_path(
             corner_style = GrpcPathCornerType.SHARP
         else:
             corner_style = GrpcPathCornerType.MITER
+        _points = []
+        for pt in points:
+            _pt = []
+            for coord in pt:
+                coord = GrpcValue(coord, self._pedb.active_cell)
+                _pt.append(coord)
+            _points.append(_pt)
+        points = _points
+
+        width = GrpcValue(width, self._pedb.active_cell)
+
         polygon_data = GrpcPolygonData(points=[GrpcPointData(i) for i in points])
         path = Path.create(
             layout=self._active_layout,
             layer=layer_name,
             net=net,
-            width=GrpcValue(width),
+            width=width,
             end_cap1=start_cap_style,
             end_cap2=end_cap_style,
             corner_style=corner_style,
@@ -629,6 +640,7 @@ def create_trace(
         -------
         :class:`pyedb.dotnet.database.edb_data.primitives_data.Primitive`
         """
+
         primitive = self._create_path(
             points=path_list,
             layer_name=layer_name,

src/pyedb/grpc/database/stackup.py

@@ -505,18 +505,7 @@ def _create_stackup_layer(self, layer_name, thickness, layer_type="signal", mate
         else:
             _layer_type = GrpcLayerType.DIELECTRIC_LAYER
             material = "FR4_epoxy"
-        if isinstance(thickness, str):
-            if thickness in self._pedb.variables:
-                thickness = GrpcValue(thickness, self._pedb.active_db)
-            else:
-                import re
-
-                _thickness = re.split("[-+#]", thickness)
-                _variables = [val for val in _thickness if val in self._pedb.variables]
-                if len(_variables) == len(_thickness):
-                    thickness = GrpcValue(thickness, self._pedb.active_db)
-                else:
-                    thickness = GrpcValue(thickness)
+        thickness = GrpcValue(thickness, self._pedb.active_db)
         layer = StackupLayer.create(
             name=layer_name,
             layer_type=_layer_type,

tests/grpc/system/test_edb_modeler.py

@@ -488,7 +488,7 @@ def test_unite_polygon(self):
         t3_1 = edbapp.modeler.create_trace(
             width="MS_W",
             layer_name="trace1",
-            path_list=[("-Via_S/2", "0"), ("-SL_S/2-SL_W/2", "16 mil"), ("+SL_S/2+MS_W/2", "100 mil")],
+            path_list=[("-Via_S/2", "0"), ("-SL_S/2-SL_W/2", "16 mil"), ("SL_S/2+MS_W/2", "100 mil")],
             start_cap_style="FLat",
             end_cap_style="FLat",
             net_name="t3_1",