Skip to content

Commit 1cb402d

Browse files
authored
FIX: Miscellaneous R25.2 fixes (#502)
1 parent ef8f393 commit 1cb402d

File tree

6 files changed

+25
-19
lines changed

6 files changed

+25
-19
lines changed

doc/source/api/definition.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ Classes
2929
definition.package_def.PackageDef
3030
definition.padstack_def.PadstackDef
3131
definition.padstack_def_data.PadstackDefData
32-
definition.material_def.ThermalModifier
3332
definition.solder_ball_property.SolderBallProperty
3433
definition.component_property.ComponentProperty
3534
definition.ic_component_property.ICComponentProperty

src/ansys/edb/core/definition/material_def.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
import ansys.api.edb.v1.material_def_pb2 as pb
66

77
from ansys.edb.core.definition.dielectric_material_model import DielectricMaterialModel
8+
from ansys.edb.core.definition.material_property_thermal_modifier import (
9+
MaterialPropertyThermalModifier,
10+
)
811
from ansys.edb.core.edb_defs import DefinitionObjType
912
from ansys.edb.core.inner import ObjBase, messages
1013
from ansys.edb.core.session import MaterialDefServiceStub, StubAccessor, StubType
@@ -28,10 +31,6 @@ class MaterialProperty(Enum):
2831
INVALID_PROPERTY = pb.INVALID_PROPERTY
2932

3033

31-
class ThermalModifier(ObjBase):
32-
"""Represents a thermal modifier model."""
33-
34-
3534
class MaterialDef(ObjBase):
3635
"""Represents a material definition."""
3736

@@ -236,10 +235,10 @@ def get_thermal_modifier(self, material_property_id):
236235
237236
Returns
238237
-------
239-
ThermalModifier
238+
MaterialPropertyThermalModifier
240239
Thermal modifier of the material definition.
241240
"""
242-
return ThermalModifier(
241+
return MaterialPropertyThermalModifier(
243242
self.__stub.GetThermalModifier(
244243
MaterialDef._property_message(self, material_property_id)
245244
)
@@ -253,7 +252,7 @@ def set_thermal_modifier(self, material_property_id, thermal_modifier):
253252
material_property_id : \
254253
:class:`MaterialProperty`
255254
Property ID.
256-
thermal_modifier : ThermalModifier
255+
thermal_modifier : MaterialPropertyThermalModifier
257256
Thermal modifier to set to the material definition.
258257
"""
259258
self.__stub.SetThermalModifier(
@@ -277,10 +276,10 @@ def get_anisotropic_thermal_modifier(self, material_property_id, component_id):
277276
278277
Returns
279278
-------
280-
:class:`.ThermalModifier`
279+
:class:`.MaterialPropertyThermalModifier`
281280
Anisotropic thermal modifier of the material definition.
282281
"""
283-
return ThermalModifier(
282+
return MaterialPropertyThermalModifier(
284283
self.__stub.GetAnisotropicThermalModifier(
285284
pb.MaterialDefPropertyComponentMessage(
286285
materialDef=messages.edb_obj_message(self),
@@ -302,7 +301,7 @@ def set_anisotropic_thermal_modifier(
302301
Property ID.
303302
component_id : int
304303
Component ID.
305-
thermal_modifier : :class:`.ThermalModifier`
304+
thermal_modifier : :class:`.MaterialPropertyThermalModifier`
306305
Anisotropic thermal modifier to set to the material definition.
307306
"""
308307
self.__stub.SetAnisotropicThermalModifier(

src/ansys/edb/core/definition/padstack_def_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def layer_names(self):
118118
This property is read-only.
119119
"""
120120
layer_names_msg = self.__stub.GetLayerNames(self.msg).names
121-
return layer_names_msg
121+
return list(layer_names_msg)
122122

123123
@property
124124
def layer_ids(self):
@@ -127,7 +127,7 @@ def layer_ids(self):
127127
This property is read-only.
128128
"""
129129
layer_ids_msg = self.__stub.GetLayerIds(self.msg)
130-
return layer_ids_msg.ids
130+
return list(layer_ids_msg.ids)
131131

132132
def add_layers(self, names):
133133
"""

src/ansys/edb/core/inner/base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ def is_null(self):
2323
2424
This property is read-only.
2525
"""
26+
if (buffer := get_buffer()) is not None:
27+
buffer.flush()
2628
return self.id == 0
2729

2830
@property
@@ -46,7 +48,7 @@ def msg(self):
4648
if io_mgr.is_enabled:
4749
if self._is_future:
4850
msg.is_future = True
49-
get_io_manager().active_request_edb_obj_msg_mgr.add_active_request_edb_obj_msg(msg)
51+
io_mgr.active_request_edb_obj_msg_mgr.add_active_request_edb_obj_msg(msg)
5052
return msg
5153

5254
@msg.setter

src/ansys/edb/core/layout/mcad_model.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,31 +54,31 @@ def is_mcad(cls, connectable):
5454
5555
This method makes a call directly on a :term:`Connectable`.
5656
"""
57-
return cls.__stub.IsMcad(messages.edb_obj_message(connectable))
57+
return cls.__stub.IsMcad(messages.edb_obj_message(connectable)).value
5858

5959
@classmethod
6060
def is_mcad_stride(cls, connectable):
6161
"""Determine if a connectable object is a Stride model.
6262
6363
This method makes a call directly on a :term:`Connectable`.
6464
"""
65-
return cls.__stub.IsMcadStride(messages.edb_obj_message(connectable))
65+
return cls.__stub.IsMcadStride(messages.edb_obj_message(connectable)).value
6666

6767
@classmethod
6868
def is_mcad_hfss(cls, connectable):
6969
"""Determine if a connectable object is an HFSS model.
7070
7171
This method makes a call directly on a :term:`Connectable`.
7272
"""
73-
return cls.__stub.IsMcadHfss(messages.edb_obj_message(connectable))
73+
return cls.__stub.IsMcadHfss(messages.edb_obj_message(connectable)).value
7474

7575
@classmethod
7676
def is_mcad_3d_comp(cls, connectable):
7777
"""Determine if a connectable object is a 3D component model.
7878
7979
This method makes a call directly on a :term:`Connectable`.
8080
"""
81-
return cls.__stub.IsMcad3dComp(messages.edb_obj_message(connectable))
81+
return cls.__stub.IsMcad3dComp(messages.edb_obj_message(connectable)).value
8282

8383
@property
8484
def cell_instance(self):
@@ -108,6 +108,7 @@ def design_name(self):
108108
return self.__stub.GetDesignName(messages.edb_obj_message(self)).value
109109

110110
@property
111+
@parser.to_point3d_data
111112
def origin(self):
112113
""":class:`.Point3DData`: \
113114
Origin 3D point of the MCAD model."""

src/ansys/edb/core/net/net.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def find_by_name(cls, layout, name):
5858
@property
5959
def name(self):
6060
""":class:`str`: Name of the net."""
61-
return self.__stub.GetName(self.msg).value
61+
return self.no_net_name if self.is_no_net else self.__stub.GetName(self.msg).value
6262

6363
@name.setter
6464
def name(self, value):
@@ -119,3 +119,8 @@ def extended_net(self):
119119
"""
120120
en = self._layout_objs(LayoutObjType.NET_CLASS)[0]
121121
return None if en.is_null else en
122+
123+
@property
124+
def is_no_net(self):
125+
""":obj:`bool` Flag indicating if this the "no net" (empty) net."""
126+
return self.is_null

0 commit comments

Comments
 (0)