Skip to content

Commit 0c478fe

Browse files
authored
FIX: Fixed lambda typo, removed remaining enforce_dc_and_causality refs (#437)
1 parent e3568dd commit 0c478fe

File tree

3 files changed

+23
-26
lines changed

3 files changed

+23
-26
lines changed

src/ansys/edb/core/simulation_setup/simulation_settings.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,22 +69,22 @@ class SettingsOptions(SimulationSettingsBase):
6969
__stub: SettingsOptionsServiceStub = StubAccessor(StubType.sim_settings_options)
7070

7171
@property
72-
def do_lamda_refine(self):
72+
def do_lambda_refine(self):
7373
""":obj:`bool`: Flag indicating if lambda refinement is used during meshing."""
7474
return self.__stub.GetDoLamdaRefineFlag(self.msg).value
7575

76-
@do_lamda_refine.setter
77-
def do_lamda_refine(self, do_lamda_refine):
78-
self.__stub.SetDoLamdaRefineFlag(messages.bool_property_message(self, do_lamda_refine))
76+
@do_lambda_refine.setter
77+
def do_lambda_refine(self, do_lambda_refine):
78+
self.__stub.SetDoLamdaRefineFlag(messages.bool_property_message(self, do_lambda_refine))
7979

8080
@property
81-
def lamda_target(self):
81+
def lambda_target(self):
8282
""":obj:`float`: Target lambda value for lambda refinement."""
8383
return self.__stub.GetLamdaTarget(self.msg).value
8484

85-
@lamda_target.setter
86-
def lamda_target(self, lamda_target):
87-
self.__stub.SetLamdaTarget(messages.double_property_message(self, lamda_target))
85+
@lambda_target.setter
86+
def lambda_target(self, lambda_target):
87+
self.__stub.SetLamdaTarget(messages.double_property_message(self, lambda_target))
8888

8989
@property
9090
def mesh_size_factor(self):
@@ -96,12 +96,12 @@ def mesh_size_factor(self, mesh_size_factor):
9696
self.__stub.SetMeshSizefactor(messages.double_property_message(self, mesh_size_factor))
9797

9898
@property
99-
def use_default_lamda_value(self):
99+
def use_default_lambda_value(self):
100100
""":obj:`bool`: Flag indicating if the default lambda target value is used."""
101101
return self.__stub.GetLamdaTarget(self.msg).value
102102

103-
@use_default_lamda_value.setter
104-
def use_default_lamda_value(self, use_default_value):
103+
@use_default_lambda_value.setter
104+
def use_default_lambda_value(self, use_default_value):
105105
self.__stub.SetDoLamdaRefineFlag(messages.bool_property_message(self, use_default_value))
106106

107107

src/ansys/edb/core/simulation_setup/simulation_setup.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ class InterpolatingSweepData:
8686
Use fast sweep.
8787
adaptive_sampling : bool
8888
Use adaptive sampling.
89-
enforce_dc_and_causality : bool
90-
Enforce dc point and causality.
9189
matrix_conv_entry_list : list[MatrixConvergenceDataEntry]
9290
Matrix convergence data for frequency sweep.
9391
min_subranges : int
@@ -109,7 +107,6 @@ def __init__(self):
109107
self.use_full_basis = True
110108
self.fast_sweep = False
111109
self.adaptive_sampling = False
112-
self.enforce_dc_and_causality = False
113110
self.matrix_conv_entry_list = []
114111
self.min_subranges = 1
115112
self.min_solutions = 0
@@ -261,7 +258,6 @@ def _interpolating_sweep_data_msg(interp_sweep_data):
261258
interp_use_full_basis=interp_sweep_data.use_full_basis,
262259
fast_sweep=interp_sweep_data.fast_sweep,
263260
adaptive_sampling=interp_sweep_data.adaptive_sampling,
264-
enforce_dc_and_causality=interp_sweep_data.enforce_dc_and_causality,
265261
matrix_conv_entry_list=messages.mx_convergence_entry_msg_list(
266262
interp_sweep_data.matrix_conv_entry_list
267263
),

tests/e2e/scratch/sim_setup_scratch.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -237,17 +237,16 @@ def do_dcr_test(settings: HFSSDCRSettings):
237237

238238

239239
def do_options_test(settings: HFSSSettingsOptions):
240-
og_do_lamda_refine = settings.do_lamda_refine
241-
settings.do_lamda_refine = not og_do_lamda_refine
242-
new_do_lamda_refine = settings.do_lamda_refine
240+
og_do_lamda_refine = settings.do_lambda_refine
241+
settings.do_lambda_refine = not og_do_lamda_refine
242+
new_do_lamda_refine = settings.do_lambda_refine
243243

244-
og_lamda_target = settings.lamda_target
245-
settings.lamda_target = og_lamda_target + 0.75
246-
new_lamda_target = settings.lamda_target
247-
248-
og_use_default_lamda_value = settings.use_default_lamda_value
249-
settings.use_default_lamda_value = not og_use_default_lamda_value
250-
new_use_default_lamda_value = settings.use_default_lamda_value
244+
og_lamda_target = settings.lambda_target
245+
settings.lambda_target = og_lamda_target + 0.75
246+
new_lamda_target = settings.lambda_target
247+
og_use_default_lamda_value = settings.use_default_lambda_value
248+
settings.use_default_lambda_value = not og_use_default_lamda_value
249+
new_use_default_lamda_value = settings.use_default_lambda_value
251250

252251
og_max_refinement_per_pass = settings.max_refinement_per_pass
253252
settings.max_refinement_per_pass = og_max_refinement_per_pass + 1
@@ -308,7 +307,9 @@ def do_hfss_sim_settings_test(settings: HFSSSimulationSettings):
308307

309308

310309
def do_test():
311-
db = Database.create("test.aedb")
310+
test_db_path = "test.aedb"
311+
Database.delete(test_db_path)
312+
db = Database.create(test_db_path)
312313
test_cell = Cell.create(db, CellType.CIRCUIT_CELL, "test_cell")
313314

314315
hfss_sim_setup = HfssSimulationSetup.create(test_cell, "test_sim_setup")

0 commit comments

Comments
 (0)