Skip to content

Commit cdd2e16

Browse files
FIX: improved ibis pin load time (#6181)
Co-authored-by: pyansys-ci-bot <[email protected]>
1 parent 18d06d8 commit cdd2e16

File tree

2 files changed

+23
-21
lines changed

2 files changed

+23
-21
lines changed

doc/changelog.d/6181.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
improved ibis pin load time

src/ansys/aedt/core/generic/ibis_reader.py

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -892,8 +892,8 @@ def import_model_in_aedt(self):
892892
``True`` when the model is imported successfully, ``False`` if not imported or model already present.
893893
894894
"""
895-
896-
if [i for i in self._circuit.modeler.schematic.ocomponent_manager.GetNames() if i in self._ibis_model.buffers]:
895+
names = [i.name for i in self._ibis_model.buffers.values()]
896+
if [i for i in self._circuit.modeler.schematic.ocomponent_manager.GetNames() if i in names]:
897897
return False
898898

899899
if self._circuit:
@@ -912,22 +912,22 @@ def import_model_in_aedt(self):
912912
for buffer_item in self._ibis_model.buffers.values():
913913
arg_buffers.append(f"{buffer_item.short_name}:=")
914914
arg_buffers.append([True, "IbisSingleEnded"])
915-
model_selector_names = [i.name for i in self._ibis_model.model_selectors]
915+
# model_selector_names = [i.name for i in self._ibis_model.model_selectors]
916916
arg_components = ["NAME:Components"]
917917
for comp_value in self._ibis_model.components.values():
918918
arg_component = [f"NAME:{comp_value.name}"]
919919
for pin in comp_value.pins.values():
920920
arg_component.append(f"{pin.short_name}:=")
921-
if pin.model not in model_selector_names:
922-
arg_component.append([False, False])
923-
else:
924-
arg_component.append([True, False])
921+
# if pin.model not in model_selector_names:
922+
# arg_component.append([False, False])
923+
# else:
924+
arg_component.append([True, False])
925925
for pin in comp_value.differential_pins.values():
926926
arg_component.append(f"{pin.short_name}:=")
927-
if pin.model not in model_selector_names:
928-
arg_component.append([False, True])
929-
else:
930-
arg_component.append([True, True])
927+
# if pin.model not in model_selector_names:
928+
# arg_component.append([False, True])
929+
# else:
930+
arg_component.append([True, True])
931931
arg_components.append(arg_component)
932932

933933
args.append(arg_buffers)
@@ -1321,7 +1321,8 @@ def parse_ibis_file(self):
13211321

13221322
def import_model_in_aedt(self):
13231323

1324-
if [i for i in self._circuit.modeler.schematic.ocomponent_manager.GetNames() if i in self._ibis_model.buffers]:
1324+
names = [i.name for i in self._ibis_model.buffers.values()]
1325+
if [i for i in self._circuit.modeler.schematic.ocomponent_manager.GetNames() if i in names]:
13251326
return False
13261327
if self._circuit:
13271328
args = [
@@ -1339,22 +1340,22 @@ def import_model_in_aedt(self):
13391340
for buffer in self._ibis_model.buffers:
13401341
arg_buffers.append(f"{self._ibis_model.buffers[buffer].short_name}:=")
13411342
arg_buffers.append([True, "IbisSingleEnded"])
1342-
model_selector_names = [i.name for i in self._ibis_model.model_selectors]
1343+
# model_selector_names = [i.name for i in self._ibis_model.model_selectors]
13431344
arg_components = ["NAME:Components"]
13441345
for component in self._ibis_model.components:
13451346
arg_component = [f"NAME:{self._ibis_model.components[component].name}"]
13461347
for pin in self._ibis_model.components[component].pins.values():
13471348
arg_component.append(f"{pin.short_name}:=")
1348-
if model_selector_names and pin.model not in model_selector_names:
1349-
arg_component.append([False, False])
1350-
else:
1351-
arg_component.append([True, False])
1349+
# if model_selector_names and pin.model not in model_selector_names:
1350+
# arg_component.append([False, False])
1351+
# else:
1352+
arg_component.append([True, False])
13521353
for pin in self._ibis_model.components[component].differential_pins.values():
13531354
arg_component.append(f"{pin.short_name}:=")
1354-
if model_selector_names and pin.model not in model_selector_names:
1355-
arg_component.append([False, True])
1356-
else:
1357-
arg_component.append([True, True])
1355+
# if model_selector_names and pin.model not in model_selector_names:
1356+
# arg_component.append([False, True])
1357+
# else:
1358+
arg_component.append([True, True])
13581359
arg_components.append(arg_component)
13591360

13601361
args.append(arg_buffers)

0 commit comments

Comments
 (0)