Skip to content

Commit 8ad24d3

Browse files
maxcapodi78PipKat
andauthored
Apply suggestions from code review
Co-authored-by: Kathy Pippert <[email protected]>
1 parent f623a2e commit 8ad24d3

File tree

1 file changed

+19
-18
lines changed

1 file changed

+19
-18
lines changed

pyaedt/circuit.py

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,8 @@ def get_ibis_model_from_file(self, input_file, is_ami=False):
431431
input_file : str
432432
Path of the IBIS file.
433433
is_ami : bool, optional
434-
Whether if import an IBIS or an IBIS AMI.
434+
Whether the file to import is an IBIS AMI file. The
435+
default is ``False``, in which case it is an IBIS file.
435436
436437
Returns
437438
-------
@@ -956,11 +957,11 @@ def create_touchstone_report(
956957
curves : list
957958
List of names for the curves to plot.
958959
solution : str, optional
959-
Name of the solution. The default value is ``None``.
960+
Name of the solution. The default is ``None``.
960961
variations : dict, optional
961-
Dictionary of variation names. The default value is ``None``.
962+
Dictionary of variation names. The default is ``None``.
962963
differential_pairs : bool, optional
963-
Specify if the plot is on differential pairs traces. The default value is ``False``.
964+
Whether the plot is on differential pairs traces. The default is ``False``.
964965
subdesign_id : int, optional
965966
Specify a subdesign ID to export a Touchstone file of this subdesign. The default value is ``None``.
966967
Returns
@@ -1047,7 +1048,7 @@ def push_time_excitations(
10471048
kaiser : float, optional
10481049
Kaiser value. The default is ``0.0``.
10491050
correct_coherent_gain : bool, optional
1050-
Enable coherent gain correction. The default is ``True``.
1051+
Whether to enable the coherent gain correction. The default is ``True``.
10511052
setup : str, optional
10521053
Name of the solution setup to push. The default is ``"LinearFrequency"``.
10531054
@@ -1222,7 +1223,7 @@ def assign_power_sinusoidal_excitation_to_ports(self, ports):
12221223

12231224
@pyaedt_function_handler(filepath="input_file")
12241225
def assign_voltage_frequency_dependent_excitation_to_ports(self, ports, input_file):
1225-
"""Assign a frequency dependent excitation to circuit ports from a frequency dependent source (.fds format).
1226+
"""Assign a frequency dependent excitation to circuit ports from a frequency dependent source (FDS format).
12261227
12271228
Parameters
12281229
----------
@@ -1283,15 +1284,15 @@ def set_differential_pair(
12831284
reference : str
12841285
Name of the terminal to use as the negative terminal.
12851286
common_mode : str, optional
1286-
Name for the common mode. Default is ``None`` in which case a unique name is chosen.
1287+
Name for the common mode. The default is ``None``, in which case a unique name is assigned.
12871288
differential_mode : str, optional
1288-
Name for the differential mode. Default is ``None`` in which case a unique name is chosen.
1289+
Name for the differential mode. The default is ``None``, in which case a unique name is assigned.
12891290
common_reference : float, optional
1290-
Reference impedance for the common mode. Units are Ohm. Default is ``25``.
1291+
Reference impedance for the common mode. The units are Ohm. The default is ``25``.
12911292
differential_reference : float, optional
12921293
Reference impedance for the differential mode. Units are Ohm. Default is ``100``.
12931294
active : bool, optional
1294-
Set the differential pair as active. Default is ``True``.
1295+
Whether to set the differential pair as active. The default is ``True``.
12951296
12961297
Returns
12971298
-------
@@ -1377,7 +1378,7 @@ def set_differential_pair(
13771378
def load_diff_pairs_from_file(self, input_file):
13781379
"""Load differtential pairs definition from a file.
13791380
1380-
You can use the ``save_diff_pairs_to_file`` method to obtain the file format.
1381+
You can use the ``save_diff_pairs_to_file()`` method to obtain the file format.
13811382
New definitions are added only if they are compatible with the existing definitions in the project.
13821383
13831384
Parameters
@@ -1413,14 +1414,14 @@ def load_diff_pairs_from_file(self, input_file):
14131414

14141415
@pyaedt_function_handler(filename="output_file")
14151416
def save_diff_pairs_to_file(self, output_file):
1416-
"""Save differtential pairs definition to file.
1417+
"""Save differential pairs definition to a file.
14171418
14181419
If the file that is specified already exists, it is overwritten.
14191420
14201421
Parameters
14211422
----------
14221423
output_file : str
1423-
Full qualified name of the file containing the differential pairs definition.
1424+
Full qualified name of the file to save the differential pairs definition to.
14241425
14251426
Returns
14261427
-------
@@ -1449,7 +1450,7 @@ def add_netlist_datablock(self, input_file, name=None):
14491450
Returns
14501451
-------
14511452
bool
1452-
``True`` if successfully created, ``False`` otherwise.
1453+
``True`` when successful, ``False`` when failed.
14531454
"""
14541455
if not os.path.exists(input_file):
14551456
self.logger.error("Netlist File doesn't exists")
@@ -1465,12 +1466,12 @@ def add_netlist_datablock(self, input_file, name=None):
14651466

14661467
@pyaedt_function_handler(filepath="input_file")
14671468
def browse_log_file(self, input_file=None):
1468-
"""Save most recent log file into a new directory.
1469+
"""Save the most recent log file in a new directory.
14691470
14701471
Parameters
14711472
----------
14721473
input_file : str, optional
1473-
New log file path. The default is the pyaedt folder.
1474+
File path to save the new log file to. The default is the ``pyaedt`` folder.
14741475
14751476
Returns
14761477
-------
@@ -1644,7 +1645,7 @@ def create_tdr_schematic_from_snp(
16441645
input_file : str
16451646
Full path to the sNp file.
16461647
probe_pins : list
1647-
Pins to attach to the probe components.
1648+
List of pins to attach to the probe components.
16481649
probe_ref_pins : list, optional
16491650
Reference pins to attach to probe components. The default is ``None``.
16501651
This parameter is valid only in differential TDR probes.
@@ -1936,7 +1937,7 @@ def create_ami_schematic_from_snp(
19361937
Second and third arguments are respectively the names of the tx and rx mode probes.
19371938
"""
19381939
if design_name in self.design_list:
1939-
self.logger.warning("Design already exists. renaming.")
1940+
self.logger.warning("Design already exists. Renaming.")
19401941
design_name = generate_unique_name(design_name)
19411942
self.insert_design(design_name)
19421943
if isinstance(input_file, type(Hfss3dLayout)):

0 commit comments

Comments
 (0)