Correct bottom unflipped placement

Add a test for correct placement when the source design is unflipped and
the target design has a dielectric layer on the bottom.  To get it
working remove the dielectric elevation calculation from the Z-offset
calculation in place_in_layout_3d_placement and then clean up unused
top/bottom signal layers from the source stackup.

Behavior now should be to align the top/bottom source stackup layer with
the top/bottom target signal layer depending on the values of
(flipped_stackup, place_on_top).

Author: isaacwaldron

.gitignore

@@ -367,3 +367,12 @@ scratch_notebooks/
 
 # Visual studio code local settings
 .vscode/
+
+# EDB temp and backup files
+*.aedb.bak/
+edb.def.bak
+edb.def.tmp
+edb.def\+
+model.index.bak
+model.index.tmp
+model.index\+

_unittest/example_models/chip_flipped_stackup.aedb/edb.def

@@ -20,7 +20,7 @@
     import _unittest_ironpython.conf_unittest as pytest
 
 
-class TestGalileo(BasisTest, object):
+class TestClass(BasisTest, object):
     def setup_class(self):
         BasisTest.my_setup(self)
         self.edbapp = BasisTest.add_edb(self, test_project_name)
@@ -766,9 +766,7 @@ def test_81_edb_with_dxf(self):
         edb3.close_edb()
         del edb3
 
-
-class TestOthers(BasisTest, object):
-    def test_00_place_on_lam_with_mold(self):
+    def test_82_place_on_lam_with_mold(self):
         laminateEdb = Edb(os.path.join(local_path, "example_models", "lam_with_mold.aedb"), edbversion=desktop_version)
         chipEdb = Edb(os.path.join(local_path, "example_models", "chip.aedb"), edbversion=desktop_version)
         try:
@@ -806,3 +804,43 @@ def test_00_place_on_lam_with_mold(self):
         finally:
             chipEdb.close_edb()
             laminateEdb.close_edb()
+
+    def test_82b_place_on_bottom_of_lam_with_mold(self):
+        laminateEdb = Edb(os.path.join(local_path, "example_models", "lam_with_mold.aedb"), edbversion=desktop_version)
+        chipEdb = Edb(os.path.join(local_path, "example_models", "chip_flipped_stackup.aedb"), edbversion=desktop_version)
+        try:
+            layout = laminateEdb.active_layout
+            cellInstances = list(layout.CellInstances)
+            assert len(cellInstances) == 0
+            assert chipEdb.core_stackup.place_in_layout_3d_placement(
+                laminateEdb,
+                angle=0.0,
+                offset_x=0.0,
+                offset_y=0.0,
+                flipped_stackup=False,
+                place_on_top=False
+            )
+            merged_cell = chipEdb.edb.Cell.Cell.FindByName(chipEdb.db, chipEdb.edb.Cell.CellType.CircuitCell, 'lam_with_mold')
+            assert not merged_cell.IsNull()
+            layout = merged_cell.GetLayout()
+            cellInstances = list(layout.CellInstances)
+            assert len(cellInstances) == 1
+            cellInstance = cellInstances[0]
+            assert cellInstance.Is3DPlacement()
+            if is_ironpython:
+                res, localOrigin, rotAxisFrom, rotAxisTo, angle, loc = cellInstance.Get3DTransformation()
+            else:
+                res, localOrigin, rotAxisFrom, rotAxisTo, angle, loc = cellInstance.Get3DTransformation(None, None, None, None, None)
+            assert res
+            zeroValue = chipEdb.edb_value(0)
+            oneValue = chipEdb.edb_value(1)
+            originPoint = chipEdb.edb.Geometry.Point3DData(zeroValue, zeroValue, zeroValue)
+            xAxisPoint = chipEdb.edb.Geometry.Point3DData(oneValue, zeroValue, zeroValue)
+            assert localOrigin.IsEqual(originPoint)
+            assert rotAxisFrom.IsEqual(xAxisPoint)
+            assert rotAxisTo.IsEqual(xAxisPoint)
+            assert angle.IsEqual(zeroValue)
+            assert loc.IsEqual(chipEdb.edb.Geometry.Point3DData(zeroValue, zeroValue, chipEdb.edb_value(-90e-6)))
+        finally:
+            chipEdb.close_edb()
+            laminateEdb.close_edb()

_unittest/example_models/lam_with_mold.aedb/edb.def

@@ -535,18 +535,11 @@ def place_in_layout_3d_placement(
             res_s = stackup_source.GetTopBottomStackupLayers(stack_set)
             source_stack_top_elevation = res_s[2]
             source_stack_bot_elevation = res_s[4]
-            res2 = stackup_source.GetTopBottomStackupLayers(sig_set)
-            source_sig_top_elevation = res2[2]
-            source_sig_bot_elevation = res2[4]
         else:
             target_top = None
             target_top_elevation = Double(0.0)
             target_bottom = None
             target_bottom_elevation = Double(0.0)
-            source_sig_top = None
-            source_sig_top_elevation = Double(0.0)
-            source_sig_bot = None
-            source_sig_bot_elevation = Double(0.0)
             source_stack_top = None
             source_stack_top_elevation = Double(0.0)
             source_stack_bot = None
@@ -558,31 +551,22 @@ def place_in_layout_3d_placement(
             res_s = stackup_source.GetTopBottomStackupLayers(
                 stack_set, source_stack_top, source_stack_top_elevation, source_stack_bot, source_stack_bot_elevation
             )
-            res2 = stackup_source.GetTopBottomStackupLayers(
-                sig_set, source_sig_top, source_sig_top_elevation, source_sig_bot, source_sig_bot_elevation
-            )
             target_top_elevation = res[2]
             target_bottom_elevation = res[4]
             source_stack_top_elevation = res_s[2]
             source_stack_bot_elevation = res_s[4]
-            source_sig_top_elevation = res2[2]
-            source_sig_bot_elevation = res2[4]
         if place_on_top and flipped_stackup:
             elevation = target_top_elevation + source_stack_top_elevation
-            diel_elevation = source_stack_top_elevation - source_sig_top_elevation
         elif place_on_top:
             elevation = target_top_elevation + source_stack_bot_elevation
-            diel_elevation = source_sig_bot_elevation - source_stack_bot_elevation
         elif flipped_stackup:
             elevation = target_bottom_elevation - source_stack_bot_elevation
-            diel_elevation = source_stack_bot_elevation - source_sig_bot_elevation
             solder_height = -solder_height
         else:
-            elevation = target_bottom_elevation - source_sig_top_elevation
-            diel_elevation = target_bottom_elevation - source_stack_bot_elevation
+            elevation = target_bottom_elevation - source_stack_top_elevation
             solder_height = -solder_height
 
-        h_stackup = self._edb_value(elevation + solder_height - diel_elevation)
+        h_stackup = self._edb_value(elevation + solder_height)
 
         zero_data = self._edb_value(0.0)
         one_data = self._edb_value(1.0)