Add acceptance tests for Job template data source

Author: lranjbar

internal/provider/job_template_data_source.go

@@ -117,7 +117,7 @@ func (d *JobTemplateDataSource) Read(ctx context.Context, req datasource.ReadReq
 		return
 	}
 
-	uri := path.Join(d.client.getApiEndpoint(), "inventories")
+	uri := path.Join(d.client.getApiEndpoint(), "job_templates")
 	resourceURL, err := ReturnAAPNamedURL(state.Id, state.Name, state.OrganizationName, uri)
 	if err != nil {
 		resp.Diagnostics.AddError("Minimal Data Not Supplied", "Require [id] or [name and organization_name]")

internal/provider/job_template_data_source_test.go

@@ -0,0 +1,150 @@
+package provider
+
+import (
+	"context"
+	"fmt"
+	"os"
+	"testing"
+
+	"github.com/ansible/terraform-provider-aap/internal/provider/customtypes"
+	fwdatasource "github.com/hashicorp/terraform-plugin-framework/datasource"
+	"github.com/hashicorp/terraform-plugin-framework/diag"
+	"github.com/hashicorp/terraform-plugin-framework/types"
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+)
+
+func TestJobTemplateDataSourceSchema(t *testing.T) {
+	t.Parallel()
+
+	ctx := context.Background()
+	schemaRequest := fwdatasource.SchemaRequest{}
+	schemaResponse := &fwdatasource.SchemaResponse{}
+
+	// Instantiate the InventoryDataSource and call its Schema method
+	NewJobTemplateDataSource().Schema(ctx, schemaRequest, schemaResponse)
+
+	if schemaResponse.Diagnostics.HasError() {
+		t.Fatalf("Schema method diagnostics: %+v", schemaResponse.Diagnostics)
+	}
+
+	// Validate the schema
+	diagnostics := schemaResponse.Schema.ValidateImplementation(ctx)
+
+	if diagnostics.HasError() {
+		t.Fatalf("Schema validation diagnostics: %+v", diagnostics)
+	}
+}
+
+func TestJobTemplateDataSourceParseHttpResponse(t *testing.T) {
+	jsonError := diag.Diagnostics{}
+	jsonError.AddError("Error parsing JSON response from AAP", "invalid character 'N' looking for beginning of value")
+
+	var testTable = []struct {
+		name     string
+		input    []byte
+		expected JobTemplateDataSourceModel
+		errors   diag.Diagnostics
+	}{
+		{
+			name:     "JSON error",
+			input:    []byte("Not valid JSON"),
+			expected: JobTemplateDataSourceModel{},
+			errors:   jsonError,
+		},
+		{
+			name:  "missing values",
+			input: []byte(`{"id":1,"organization":2,"url":"/job_templates/1/"}`),
+			expected: JobTemplateDataSourceModel{
+				Id:               types.Int64Value(1),
+				Organization:     types.Int64Value(2),
+				OrganizationName: types.StringValue(""),
+				Url:              types.StringValue("/job_templates/1/"),
+				NamedUrl:         types.StringValue(""),
+				Name:             types.StringNull(),
+				Description:      types.StringNull(),
+				Variables:        customtypes.NewAAPCustomStringNull(),
+			},
+			errors: diag.Diagnostics{},
+		},
+		{
+			name: "all values",
+			input: []byte(
+				`{"id":1,"organization":2,"url":"/job_templates/1/","name":"my job template","description":"My Test Job Template","variables":"{\"foo\":\"bar\"}"}`,
+			),
+			expected: JobTemplateDataSourceModel{
+				Id:               types.Int64Value(1),
+				Organization:     types.Int64Value(2),
+				OrganizationName: types.StringValue(""),
+				Url:              types.StringValue("/job_templates/1/"),
+				NamedUrl:         types.StringValue(""),
+				Name:             types.StringValue("my job template"),
+				Description:      types.StringValue("My Test Job Template"),
+				Variables:        customtypes.NewAAPCustomStringValue("{\"foo\":\"bar\"}"),
+			},
+			errors: diag.Diagnostics{},
+		},
+	}
+
+	for _, test := range testTable {
+		t.Run(test.name, func(t *testing.T) {
+			source := JobTemplateDataSourceModel{}
+			diags := source.ParseHttpResponse(test.input)
+			if !test.errors.Equal(diags) {
+				t.Errorf("Expected error diagnostics (%s), Received (%s)", test.errors, diags)
+			}
+			if test.expected != source {
+				t.Errorf("Expected (%s) not equal to actual (%s)", test.expected, source)
+			}
+		})
+	}
+}
+
+func TestAccJobTemplateDataSource(t *testing.T) {
+	jobTemplateID := os.Getenv("AAP_TEST_JOB_TEMPLATE_ID")
+	jobTemplateName := "Demo Job Template"
+	jobTemplateOrg := "Default"
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { testAccPreCheck(t) },
+		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			// Read
+			{
+				Config: testAccJobTemplateDataSourceFromId(jobTemplateID),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttrSet("data.aap_job_template.test", "name"),
+					resource.TestCheckResourceAttrSet("data.aap_job_template.test", "organization"),
+					resource.TestCheckResourceAttrSet("data.aap_job_template.test", "url"),
+				),
+			},
+			// Read
+			{
+				Config: testAccJobTemplateDataSourceFromNamedUrl(jobTemplateName, jobTemplateOrg),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttrSet("data.aap_job_template.test", "name"),
+					resource.TestCheckResourceAttrSet("data.aap_job_template.test", "organization"),
+					resource.TestCheckResourceAttrSet("data.aap_job_template.test", "url"),
+				),
+			},
+		},
+		CheckDestroy: testAccCheckInventoryResourceDestroy,
+	})
+}
+
+// testAccInventoryDataSource configures the Inventory Data Source for testing
+func testAccJobTemplateDataSourceFromId(id string) string {
+	return fmt.Sprintf(`
+data "aap_job_template" "test" {
+  id = %s
+}
+`, id)
+}
+
+func testAccJobTemplateDataSourceFromNamedUrl(name string, orgName string) string {
+	return fmt.Sprintf(`
+data "aap_job_template" "test" {
+  name = "%s"
+  organization_name = "%s"
+}
+`, name, orgName)
+}