Update hooks (#393)

Author: ssbarnea

.config/constraints.txt

@@ -1,8 +1,8 @@
 # This file was autogenerated by uv via the following command:
 #    tox run -e deps
-ansible-compat==25.1.4    # via ansible-lint
-ansible-lint==25.1.3      # via ansible-creator (pyproject.toml)
-argcomplete==3.6.1        # via ansible-creator (pyproject.toml)
+ansible-compat==25.1.5    # via ansible-lint
+ansible-lint==25.2.1      # via ansible-creator (pyproject.toml)
+argcomplete==3.6.2        # via ansible-creator (pyproject.toml)
 astroid==3.3.9            # via pylint
 attrs==25.3.0             # via jsonschema, referencing
 babel==2.17.0             # via mkdocs-material
@@ -19,8 +19,8 @@ cfgv==3.4.0               # via pre-commit
 chardet==5.2.0            # via tox
 charset-normalizer==3.4.1  # via requests
 click==8.1.8              # via black, mkdocs, pydoclint
-colorama==0.4.6           # via click, griffe, mkdocs, mkdocs-material, pylint, pytest, tox
-coverage==7.7.1           # via ansible-creator (pyproject.toml)
+colorama==0.4.6           # via griffe, mkdocs-material, tox
+coverage==7.8.0           # via ansible-creator (pyproject.toml)
 cryptography==44.0.2      # via ansible-core
 csscompressor==0.9.5      # via mkdocs-minify-plugin
 cssselect2==0.8.0         # via cairosvg
@@ -32,7 +32,7 @@ docstring-parser-fork==0.0.12  # via pydoclint
 execnet==2.1.1            # via pytest-xdist
 filelock==3.18.0          # via ansible-lint, tox, virtualenv
 ghp-import==2.1.0         # via mkdocs
-griffe==1.7.1             # via mkdocstrings-python
+griffe==1.7.2             # via mkdocstrings-python
 hjson==3.1.0              # via mkdocs-macros-plugin, super-collections
 htmlmin2==0.1.13          # via mkdocs-minify-plugin
 identify==2.6.9           # via pre-commit
@@ -58,29 +58,32 @@ mkdocs-gen-files==0.5.0   # via mkdocs-ansible
 mkdocs-get-deps==0.2.0    # via mkdocs
 mkdocs-htmlproofer-plugin==1.3.0  # via mkdocs-ansible
 mkdocs-macros-plugin==1.3.7  # via mkdocs-ansible
-mkdocs-material==9.6.9    # via mkdocs-ansible
+mkdocs-material==9.6.11   # via mkdocs-ansible
 mkdocs-material-extensions==1.3.1  # via mkdocs-ansible, mkdocs-material
 mkdocs-minify-plugin==0.8.0  # via mkdocs-ansible
 mkdocs-monorepo-plugin==1.1.0  # via mkdocs-ansible
-mkdocstrings==0.29.0      # via mkdocs-ansible, mkdocstrings-python
-mkdocstrings-python==1.16.8  # via mkdocs-ansible
+mkdocstrings==0.29.1      # via mkdocs-ansible, mkdocstrings-python
+mkdocstrings-python==1.16.10  # via mkdocs-ansible
 mypy==1.15.0              # via ansible-creator (pyproject.toml)
 mypy-extensions==1.0.0    # via black, mypy
 nodeenv==1.9.1            # via pre-commit
-packaging==24.2           # via ansible-compat, ansible-core, ansible-lint, black, mkdocs, mkdocs-macros-plugin, pyproject-api, pytest, tox
+packaging==24.2           # via ansible-compat, ansible-core, ansible-lint, black, mkdocs, mkdocs-macros-plugin, pyproject-api, pytest, pytest-sugar, tox
 paginate==0.5.7           # via mkdocs-material
 pathspec==0.12.1          # via ansible-lint, black, mkdocs, mkdocs-macros-plugin, yamllint
 pillow==11.1.0            # via cairosvg, mkdocs-ansible
 platformdirs==4.3.7       # via black, mkdocs-get-deps, pylint, tox, virtualenv
 pluggy==1.5.0             # via pytest, tox
 pre-commit==4.2.0         # via ansible-creator (pyproject.toml)
 pycparser==2.22           # via cffi
-pydoclint==0.6.2          # via ansible-creator (pyproject.toml)
+pydoclint==0.6.5          # via ansible-creator (pyproject.toml)
 pygments==2.19.1          # via mkdocs-material
 pylint==3.3.6             # via ansible-creator (pyproject.toml)
 pymdown-extensions==10.14.3  # via markdown-exec, mkdocs-ansible, mkdocs-material, mkdocstrings
 pyproject-api==1.9.0      # via tox
-pytest==8.3.5             # via pytest-xdist, ansible-creator (pyproject.toml)
+pytest==8.3.5             # via pytest-instafail, pytest-plus, pytest-sugar, pytest-xdist, ansible-creator (pyproject.toml)
+pytest-instafail==0.5.0   # via ansible-creator (pyproject.toml)
+pytest-plus==0.8.1        # via ansible-creator (pyproject.toml)
+pytest-sugar==1.0.0       # via ansible-creator (pyproject.toml)
 pytest-xdist==3.6.1       # via ansible-creator (pyproject.toml)
 python-dateutil==2.9.0.post0  # via ghp-import, mkdocs-macros-plugin
 python-slugify==8.0.4     # via mkdocs-monorepo-plugin
@@ -90,20 +93,20 @@ referencing==0.36.2       # via ansible-lint, jsonschema, jsonschema-specificati
 requests==2.32.3          # via linkchecker, mkdocs-htmlproofer-plugin, mkdocs-material
 rpds-py==0.24.0           # via jsonschema, referencing
 ruamel-yaml==0.18.10      # via ansible-lint
-ruff==0.11.2              # via ansible-creator (pyproject.toml)
+ruff==0.11.3              # via ansible-creator (pyproject.toml)
 six==1.17.0               # via python-dateutil
 soupsieve==2.6            # via beautifulsoup4
 subprocess-tee==0.4.2     # via ansible-compat, ansible-lint
 super-collections==0.5.3  # via mkdocs-macros-plugin
-termcolor==2.5.0          # via mkdocs-macros-plugin
+termcolor==3.0.1          # via mkdocs-macros-plugin, pytest-sugar
 text-unidecode==1.3       # via python-slugify
 tinycss2==1.4.0           # via cairosvg, cssselect2
 toml-sort==0.24.2         # via ansible-creator (pyproject.toml)
 tomlkit==0.13.2           # via pylint, toml-sort
 tox==4.25.0               # via ansible-creator (pyproject.toml)
-types-pyyaml==6.0.12.20250326  # via ansible-creator (pyproject.toml)
+types-pyyaml==6.0.12.20250402  # via ansible-creator (pyproject.toml)
 urllib3==2.3.0            # via requests
-virtualenv==20.29.3       # via pre-commit, tox
+virtualenv==20.30.0       # via pre-commit, tox
 watchdog==6.0.0           # via mkdocs
 wcmatch==10.0             # via ansible-lint
 webencodings==0.5.1       # via cssselect2, tinycss2

.config/pydoclint-baseline.txt

@@ -0,0 +1,83 @@
+tests/fixtures/collection/testorg/testcol/tests/integration/test_integration.py
+    DOC502: Function `test_integration` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/fixtures/collection/testorg/testcol/tests/unit/test_basic.py
+    DOC502: Function `test_basic` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/integration/test_init.py
+    DOC502: Function `test_run_help` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_no_subcommand` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_init_no_input` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_deprecated_failure` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_init_invalid_name` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_init_basic` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_init_ee` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/integration/test_lint.py
+    DOC502: Function `test_lint_collection` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_lint_playbook_project` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_add.py
+    DOC502: Function `test_run_success_add_devfile` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_error_no_overwrite` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_error_invalid_path` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_error_invalid_collection_path` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_error_unsupported_resource_type` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_devcontainer` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_plugin_filter` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_plugin_lookup` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_plugin_action` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_plugin_module` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_plugin_test` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_error_plugin_no_overwrite` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_error_unsupported_plugin_type` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_add_execution_env` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_update_galaxy_dependency` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_argparse_help.py
+    DOC502: Function `test_custom_help_single` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_custom_help_double` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_basic.py
+    DOC502: Function `test_configuration_class` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_cli_parser` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_missing_j2` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_cli_init_output` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_cli_main` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_collection_name_short` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_collection_name_invalid` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_is_a_tty` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_not_a_tty` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_main` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_proj_main` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_coming_soon` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_config_post_init` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_compat.py
+    DOC502: Function `test_import` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_init.py
+    DOC502: Function `test_run_success_for_collection` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_ee_project` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_ansible_project` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_run_success_collections_alt_dir` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_delete_error` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_is_file_error` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_name_in_devfile_collection` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_name_in_devfile_playbook` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_templar.py
+    DOC502: Function `test_templar` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_templar_json_simple` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_templar_json_complex` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------
+tests/units/test_utils.py
+    DOC502: Function `test_expand_path` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_skip_dirs` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_overwrite` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_skip_repeats` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_ask_yes_no_yes` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_ask_yes_no_no` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_ask_yes_no_invalid_then_yes` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+    DOC502: Function `test_ask_yes_no_invalid_then_no` has a "Raises" section in the docstring, but there are not "raise" statements in the body
+--------------------

.config/requirements-test.in

@@ -7,6 +7,9 @@ pydoclint
 pylint
 pytest
 pytest-xdist
+pytest-sugar
+pytest-instafail
+pytest-plus
 ruff
 toml-sort
 tox

.pre-commit-config.yaml

@@ -11,6 +11,9 @@ ci:
     # No docker on pre-commit.ci
 
 repos:
+  - repo: meta
+    hooks:
+      - id: check-useless-excludes
   - repo: https://github.com/rbubley/mirrors-prettier
     # keep it before yamllint
     rev: v3.5.3
@@ -20,6 +23,11 @@ repos:
         additional_dependencies:
           - prettier
           - [email protected]
+  - repo: https://github.com/streetsidesoftware/cspell-cli
+    rev: v8.17.3
+    hooks:
+      - id: cspell
+        name: Spell check with cspell
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0
     hooks:
@@ -54,59 +62,45 @@ repos:
     rev: v0.24.2
     hooks:
       - id: toml-sort-fix
+        alias: toml
 
   - repo: https://github.com/tox-dev/tox-ini-fmt
     rev: 1.5.0
     hooks:
       - id: tox-ini-fmt
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.9
+    rev: v0.11.3
     hooks:
       - id: ruff
-        args:
-          - --fix
-          - --exit-non-zero-on-fix
-        types_or: [python, pyi]
-      - id: ruff-format # must be after ruff
-        types_or: [python, pyi]
-
-  - repo: https://github.com/streetsidesoftware/cspell-cli
-    rev: v8.17.3
+        entry: sh -c 'ruff check --fix --force-exclude && ruff format --force-exclude'
+  - repo: https://github.com/pre-commit/mirrors-mypy.git
+    rev: v1.15.0
     hooks:
-      - id: cspell
-        name: Spell check with cspell
-
+      - id: mypy
+        additional_dependencies: &deps
+          - argcomplete
+          - jinja2
+          - pytest
+          - pyyaml
+          - types-pyyaml
+        # Override default pre-commit '--ignore-missing-imports'
+        args: []
   - repo: https://github.com/jsh9/pydoclint
-    rev: "0.6.2"
+    rev: "0.6.5"
     hooks:
       - id: pydoclint
         # This allows automatic reduction of the baseline file when needed.
         entry: sh -ec "pydoclint . && pydoclint --generate-baseline=1 ."
         pass_filenames: false
 
   - repo: https://github.com/pycqa/pylint.git
-    rev: v3.3.4
+    rev: v3.3.6
     hooks:
       - id: pylint
         args:
           - --output-format=colorized
-        additional_dependencies:
-          - jinja2
-          - pytest
-          - pyyaml
-
-  - repo: https://github.com/pre-commit/mirrors-mypy.git
-    rev: v1.15.0
-    hooks:
-      - id: mypy
-        additional_dependencies:
-          - argcomplete
-          - jinja2
-          - pytest
-          - types-pyyaml
-        # Override default pre-commit '--ignore-missing-imports'
-        args: [--strict]
+        additional_dependencies: *deps
 
   # Keep last due to being considerably slower than the others:
   - repo: local
@@ -117,22 +111,20 @@ repos:
         files: ^(pyproject\.toml|\.config/.*)$
         always_run: true
         language: python
-        language_version: "3.10" # minimal we support officially https://github.com/astral-sh/uv/issues/3883
-        entry: python3 -m uv pip compile -q --all-extras --universal --output-file=.config/constraints.txt pyproject.toml --upgrade
+        entry: python3 -m uv pip compile -q --all-extras --python-version=3.10 --output-file=.config/constraints.txt pyproject.toml --upgrade
         pass_filenames: false
         stages:
           - manual
         additional_dependencies:
-          - uv>=0.5.25
+          - uv>=0.6.6
       - id: lock
         name: Check constraints files and requirements
         files: ^(pyproject\.toml|\.config/.*)$
         language: python
-        language_version: "3.10" # minimal we support officially https://github.com/astral-sh/uv/issues/3883
-        entry: python3 -m uv pip compile -q --all-extras --universal --output-file=.config/constraints.txt pyproject.toml
+        entry: uv pip compile -q --all-extras --python-version=3.10 --output-file=.config/constraints.txt pyproject.toml
         pass_filenames: false
         additional_dependencies:
-          - uv>=0.5.25
+          - uv>=0.6.6
   - repo: https://github.com/mashi/codecov-validator
     rev: "1.0.1"
     hooks:

.python-version

@@ -0,0 +1,3 @@
+3.10
+
+# Needed by dependabot, see https://github.com/dependabot/dependabot-core/issues/1455

.taplo.toml

@@ -0,0 +1,10 @@
+[formatting]
+# cspell: disable-next-line
+# compatibility between toml-sort-fix pre-commit hook and panekj.even-betterer-toml extension
+align_comments = false
+array_trailing_comma = false
+compact_arrays = true
+compact_entries = false
+compact_inline_tables = true
+inline_table_expand = false
+reorder_keys = true

.vscode/extensions.json

@@ -8,7 +8,10 @@
     "ms-python.mypy-type-checker",
     "ms-python.pylint",
     "ms-python.python",
-    "sonarsource.sonarlint-vscode",
-    "streetsidesoftware.code-spell-checker"
+    "redhat.ansible",
+    "redhat.vscode-yaml",
+    "streetsidesoftware.code-spell-checker",
+    "tamasfe.even-better-toml",
+    "timonwong.shellcheck"
   ]
 }

ansible.cfg

@@ -0,0 +1 @@
+# User during testing to ensure local user config does not affect testing

pyproject.toml

@@ -348,7 +348,7 @@ select = ["ALL"]
 parametrize-values-type = "tuple"
 
 [tool.ruff.lint.isort]
-known-first-party = ["ansible_creator"]
+known-first-party = ["src"]
 lines-after-imports = 2 # Ensures consistency for cases when there's variable vs function/class definitions after imports
 lines-between-types = 1 # Separate import/from with 1 line
 required-imports = ["from __future__ import annotations"]

src/ansible_creator/types.py

@@ -1,4 +1,3 @@
-# noqa: A005
 """A home for shared types."""
 
 from __future__ import annotations