Avoid reporting matcherrors against cwd (#1440)

Removes the default use of cwd  for filename for matcherrors raised
during parsing. In some particular cases the errors would endup
without a valid filename, making hard to find the problem.

Author: ssbarnea

docs/usage.rst

@@ -100,7 +100,7 @@ the following:
 If playbooks include other playbooks, or tasks, or handlers or roles, these
 are also handled:
 
-.. command-output:: ansible-lint -p examples/playbooks/include.yml
+.. command-output:: ansible-lint --offline -p examples/playbooks/include.yml
    :cwd: ..
    :returncode: 2
    :nostderr:

src/ansiblelint/errors.py

@@ -1,6 +1,5 @@
 """Exceptions and error representations."""
 import functools
-import os
 from typing import Any, Optional, Union
 
 from ansiblelint._internal.rules import BaseRule, RuntimeErrorRule
@@ -47,13 +46,12 @@ def __init__(
         self.linenumber = linenumber
         self.column = column
         self.details = details
+        self.filename = ""
         if filename:
             if isinstance(filename, Lintable):
                 self.filename = normpath(str(filename.path))
             else:
                 self.filename = normpath(filename)
-        else:
-            self.filename = os.getcwd()
         self.rule = rule
         self.ignored = False  # If set it will be displayed but not counted as failure
         # This can be used by rules that can report multiple errors type, so

src/ansiblelint/formatters/__init__.py

@@ -43,7 +43,7 @@ def _format_path(self, path: Union[str, Path]) -> str:
         if isinstance(path, Path):
             path = str(path)  # Drop when Python 3.5 is no longer supported
 
-        if not self._base_dir:
+        if not self._base_dir or not path:
             return path
         # Use os.path.relpath 'cause Path.relative_to() misbehaves
         return os.path.relpath(path, start=self._base_dir)

src/ansiblelint/rules/MetaMainHasInfoRule.py

@@ -79,5 +79,4 @@ def matchplay(self, file: Lintable, data: "odict[str, Any]") -> List[MatchError]
                 self.create_matcherror(message=err, filename=file)
                 for err in _galaxy_info_errors_itr(galaxy_info)
             ]
-
-        return [self.create_matcherror(message="No 'galaxy_info' found")]
+        return [self.create_matcherror(message="No 'galaxy_info' found", filename=file)]

src/ansiblelint/runner.py

@@ -84,6 +84,9 @@ def is_excluded(self, file_path: str) -> bool:
 
         # Exclusions should be evaluated only using absolute paths in order
         # to work correctly.
+        if not file_path:
+            return False
+
         abs_path = os.path.abspath(file_path)
         _file_path = Path(file_path)
 
@@ -165,6 +168,8 @@ def _emit_matches(self, files: List[Lintable]) -> Generator[MatchError, None, No
                         self.lintables.add(child)
                         files.append(child)
                 except MatchError as e:
+                    if not e.filename:
+                        e.filename = str(lintable.path)
                     e.rule = LoadingFailureRule()
                     yield e
                 except AttributeError: