fix: Segfault linked to wrong TTL handling (#8)

* fix: Segfault linked to wrong TTL handling

Signed-off-by: Matthias Riegler <[email protected]>

* chore: remove unnecesary call

Signed-off-by: Matthias Riegler <[email protected]>

---------

Signed-off-by: Matthias Riegler <[email protected]>

Author: xvzf

internal/lease/leaseprovider.go

@@ -307,6 +307,7 @@ func (lp *leaseProviderImpl) insert(ctx context.Context, leaseRequest *Request)
 
 		// Update the state when it's a whitelisted transition (ACQUIRED -> SUCCESS/FAILURE)
 		existingStatus := pointer.StringDeref(existing.Status, StatusPending)
+		// Check if it's a whitelisted transition
 		leaseRequestStatus := pointer.StringDeref(leaseRequest.Status, StatusPending)
 		statusMismatch := existingStatus != leaseRequestStatus
 		allowedTransition := existingStatus == StatusAcquired && (leaseRequestStatus == StatusSuccess || leaseRequestStatus == StatusFailure)
@@ -325,6 +326,8 @@ func (lp *leaseProviderImpl) insert(ctx context.Context, leaseRequest *Request)
 			return nil, fmt.Errorf("status missmatch for commit %s; expected: `success|failure`, got: `%s`", leaseRequest.HeadSHA, leaseRequestStatus)
 		}
 
+		// Update existing request no matter if it changed or not (it's used for TTL eviction)
+		lp.updateRequestLastSeenAt(existing)
 		log.Ctx(ctx).Debug().EmbedObject(existing).Msg("Lease request updated")
 	}
 

internal/server/handlers/release.go

@@ -4,6 +4,7 @@ import (
 	"github.com/ankorstore/gh-action-mq-lease-service/internal/lease"
 	"github.com/go-playground/validator/v10"
 	"github.com/gofiber/fiber/v2"
+	"github.com/rs/zerolog/log"
 )
 
 func Release(orchestrator lease.ProviderOrchestrator) func(c *fiber.Ctx) error {
@@ -36,6 +37,7 @@ func Release(orchestrator lease.ProviderOrchestrator) func(c *fiber.Ctx) error {
 
 		leaseRequestResponse, err := provider.Release(c.UserContext(), leaseRequest)
 		if err != nil {
+			log.Ctx(c.UserContext()).Error().Err(err).Msg("Couldn't release the lock")
 			return apiError(c, fiber.StatusBadRequest, "Couldn't release the lock", err.Error())
 		}