Skip to content

Commit af02c86

Browse files
committed
feat(node): bump node support
Bump minimum node support to 14.17 (matches semantic release) and include testing for node 18. BREAKING CHANGE: Node 10 and 12 are no longer supported. 14.17+ only Fix #42
1 parent 6223ea7 commit af02c86

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

.github/workflows/cicd.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
test:
1010
strategy:
1111
matrix:
12-
node: ['12', '14', '16']
12+
node: ['14.17', '16', '18']
1313
os: [ubuntu-latest, windows-latest, macos-latest]
1414

1515
runs-on: ${{ matrix.os }}
@@ -35,7 +35,7 @@ jobs:
3535
- name: Use Node.js 14
3636
uses: actions/setup-node@v2
3737
with:
38-
node-version: '14'
38+
node-version: '14.17'
3939
cache: npm
4040
- run: npm install -g npm@latest # Standard version seems to pull in incorrect package versions
4141
- run: npm ci

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Many language service plugins work perfectly in VS Code, but using them in Visua
1313

1414
## Compatibility
1515

16-
* Node: >= 10.14
16+
* Node: >= 14.17
1717
* TypeScript >= 2.9
1818

1919
## Installation

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"src"
88
],
99
"engines": {
10-
"node": ">=10.14"
10+
"node": ">=14.17"
1111
},
1212
"scripts": {
1313
"pretest": "cd test/fixtures/workspace && npm install && cd ../../..",

test/fixtures/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ module.exports = {
2828
'3.9': { version: '3.9.9', path: path.resolve(__dirname, 'workspace', 'node_modules', 'typescript39') },
2929
'3.0': { version: '3.0.1', path: path.resolve(__dirname, 'workspace', 'node_modules', 'typescript30') },
3030
'2.9': { version: '2.9.1', path: path.resolve(__dirname, 'workspace', 'node_modules', 'typescript29') },
31-
// Can't go back further than 2.8 because tsserver won't work on node 10 (https://github.com/microsoft/TypeScript/commit/1fc3aebc20a13048d6595395f721c6b0078c2c08)
3231
// Can't go back further than 2.9 because the tsconfig warnings stop appearing
3332

3433
// Has to be a different version to all the others for the tsversion tests

0 commit comments

Comments
 (0)