Skip to content

Commit 4e04d27

Browse files
committed
Update use of slices.SortFunc
1 parent 0c4e7dd commit 4e04d27

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

bootstrap.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func (s *Server) BootstrapContext(ctx context.Context) (_ TraversalStats, err er
3434
// Track number of responses, for STM use. (It's available via atomic in TraversalStats but that
3535
// won't let wake up STM transactions that are observing the value.)
3636
t := traversal.Start(traversal.OperationInput{
37-
Target: krpc.ID(s.id.AsByteArray()),
37+
Target: s.id.AsByteArray(),
3838
K: 16,
3939
DoQuery: func(ctx context.Context, addr krpc.NodeAddr) traversal.QueryResult {
4040
return s.FindNode(NewAddr(addr.UDP()), s.id, QueryRateLimiting{}).TraversalQueryResult(addr)

cmd/dht/get-peers.go

+10-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
"github.com/anacrolix/log"
1010
"golang.org/x/exp/constraints"
11-
"golang.org/x/exp/slices"
11+
"slices"
1212

1313
"github.com/anacrolix/dht/v2"
1414
)
@@ -61,10 +61,11 @@ getPeers:
6161
Frequency: count,
6262
})
6363
}
64-
slices.SortFunc(addrCountSlice, func(a, b addrFreq) bool {
64+
slices.SortFunc(addrCountSlice, func(a, b addrFreq) int {
65+
// Looks like I got sick of anacrolix/multiless.
6566
return ordered(a.Frequency, b.Frequency).Then(
66-
lesser(a.Addr.Addr(), b.Addr.Addr())).ThenLess(
67-
a.Addr.Port() < b.Addr.Port())
67+
lesser(a.Addr.Addr(), b.Addr.Addr())).Then(
68+
ordered(a.Addr.Port(), b.Addr.Port())).ToInt()
6869
})
6970
je := json.NewEncoder(os.Stdout)
7071
je.SetIndent("", " ")
@@ -123,10 +124,12 @@ func (me Ordering) Then(other Ordering) Ordering {
123124
}
124125
}
125126

126-
func (me Ordering) ThenLess(less bool) bool {
127+
func (me Ordering) ToInt() int {
127128
if me.equal {
128-
return less
129+
return 0
130+
} else if me.less {
131+
return -1
129132
} else {
130-
return me.less
133+
return 1
131134
}
132135
}

0 commit comments

Comments
 (0)