Adding support to amp-ad for vadserver network #24230
Conversation
|
I check the required error in travis, but when I enter in details, I see something about an apt-get install issue. I have some doubts if it can be related to my code, but I want to confirm if possible, please. Thanks a lot |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@satrolkqd Looks like the apt get issue sorted itself out. Could you please try to resolve the CLA issue? Let me know if you get stuck. Thanks! |
|
|
||
| Required parameters: | ||
| - data-pid: pid for choosing ad publisher | ||
| - data-sid: sid for choosing ad in itself |
There was a problem hiding this comment.
Did you want to mention the optional param data-xtra-lkqd-settings here?
| @@ -1017,6 +1017,8 @@ const adConfig = jsonConfiguration({ | |||
| renderStartImplemented: true, | |||
| }, | |||
|
|
|||
| 'vadserver': {}, | |||
There was a problem hiding this comment.
I see you are not implementing renderStart. We recommend using this API if possible, as it will give you some performance gains, but it is optional.
|
@satrolkqd is this PR still active? /cc @ampproject/wg-ads |
|
Mario seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Closing for being inactive. |
Implemented in amp-ad support for vadserver with lkqd player.