Simplify logic to ensure -1 <= limit_per_type <= PHP_INT_MAX

Author: westonruter

src/Validation/URLScanningContext.php

@@ -80,12 +80,7 @@ public function get_limit_per_type() {
 		 */
 		$url_validation_limit_per_type = (int) apply_filters( 'amp_url_validation_limit_per_type', $this->limit_per_type );
 
-		// Valid values are any integer -1 and above.
-		if ( $url_validation_limit_per_type < -1 ) {
-			$url_validation_limit_per_type = 1;
-		}
-
-		return $url_validation_limit_per_type;
+		return max( $url_validation_limit_per_type, -1 );
 	}
 
 	/**

tests/php/src/Validation/URLScanningContextTest.php

@@ -44,7 +44,7 @@ static function() {
 				return -4;
 			}
 		);
-		$this->assertEquals( 1, $this->test_instance->get_limit_per_type() );
+		$this->assertEquals( -1, $this->test_instance->get_limit_per_type() );
 
 		add_filter(
 			'amp_url_validation_limit_per_type',