Remove vague condition that return attributes

thelovekesh · thelovekesh · commit 1131c4d13db3 · 2022-08-02T18:49:46.000+05:30
diff --git a/includes/sanitizers/class-amp-img-sanitizer.php b/includes/sanitizers/class-amp-img-sanitizer.php
@@ -546,8 +546,6 @@ private function maybe_add_lightbox_attributes( $attributes, $node ) {
 			$parent_attributes = AMP_DOM_Utils::get_node_attributes_as_assoc_array( $parent_node );
 		} elseif ( Tag::A === $parent_node->tagName && Tag::FIGURE === $parent_node->parentNode->tagName ) {
 			$parent_attributes = AMP_DOM_Utils::get_node_attributes_as_assoc_array( $parent_node->parentNode );
-		} else {
-			return $attributes;
 		}
 
 		if ( isset( $parent_attributes['data-amp-lightbox'] ) && true === filter_var( $parent_attributes['data-amp-lightbox'], FILTER_VALIDATE_BOOLEAN ) ) {

Original file line number	Diff line number	Diff line change
`@@ -546,8 +546,6 @@ private function maybe_add_lightbox_attributes( $attributes, $node ) {`
`546`	`546`	`$parent_attributes = AMP_DOM_Utils::get_node_attributes_as_assoc_array( $parent_node );`
`547`	`547`	`} elseif ( Tag::A === $parent_node->tagName && Tag::FIGURE === $parent_node->parentNode->tagName ) {`
`548`	`548`	`$parent_attributes = AMP_DOM_Utils::get_node_attributes_as_assoc_array( $parent_node->parentNode );`
`549`		`- } else {`
`550`		`- return $attributes;`
`551`	`549`	`}`
`552`	`550`
`553`	`551`	`if ( isset( $parent_attributes['data-amp-lightbox'] ) && true === filter_var( $parent_attributes['data-amp-lightbox'], FILTER_VALIDATE_BOOLEAN ) ) {`