fix: compose autocapture properties update #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polbins
reviewed
Apr 1, 2025
android/src/main/java/com/amplitude/android/internal/ViewHierarchyScanner.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/amplitude/android/internal/locators/ComposeViewTargetLocator.java
Show resolved
Hide resolved
| lastKnownTag = (String) entry.getValue(); | ||
| final Modifier modifier = modifierInfo.getModifier(); | ||
| if (modifier instanceof InspectableValue) { | ||
| final InspectableValue inspectableValue = (InspectableValue) modifier; |
There was a problem hiding this comment.
this might be a good time to convert this to Kotlin too, to get inferred types make it more succinct
There was a problem hiding this comment.
no, bcos this is a java hack for reflection
There was a problem hiding this comment.
I'm not sure I understand, it seems we don't use reflection here specifically?
polbins
approved these changes
Apr 1, 2025
|
🎉 This PR is included in version 1.20.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jira ticket: https://amplitude.atlassian.net/browse/AMP-126719
With Compose update to new version it's internal implementation of testTag changed from
SemanticsModifiertoTestTagElementThe only common part is Inspectable Value params that we can iterate.
Tested on versions:
from 1.5.+
to 1.7.+
Supported tags:
Modifier.testTag("some value")Modifier.semantics { testTag = "some value" }Clickable nodes added support for clickable InspectableValue.
Checklist