Skip to content

Commit 46a7096

Browse files
authored
[idl check] Fetch tags (jaegertracing#6758)
## Which problem is this PR solving? - The test in jaegertracing#6753 was still failing, even with the submodule update ## Description of the changes - Try to fetch tags ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <[email protected]>
1 parent ab25385 commit 46a7096

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/ci-lint-checks.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ jobs:
8282
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
8383
with:
8484
submodules: recursive
85+
fetch-tags: true
8586

8687
- name: check jaeger-idl versions across git submodule and go.mod dependency
8788
run: make lint-jaeger-idl-versions

scripts/lint/check-jaeger-idl-version.sh

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ get_gomod_version() {
1919

2020
get_submodule_version() {
2121
cd idl
22+
git fetch --tags
2223
commit_version=$(git rev-parse HEAD)
2324
semver=$(git describe --tags --exact-match "$commit_version")
2425
if [ ! "$semver" ]; then

0 commit comments

Comments
 (0)