Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 instead of 500 when params validation failed #770

Closed
c910335 opened this issue Apr 22, 2018 · 4 comments
Closed

400 instead of 500 when params validation failed #770

c910335 opened this issue Apr 22, 2018 · 4 comments

Comments

@c910335
Copy link
Contributor

c910335 commented Apr 22, 2018

Description

ValidationFailed is apparently a client error due to passing invalid params.
Thus, server should response 400 Bad Request instead of 500 Internal Server Error when ValidationFailed is raised.

Steps to Reproduce

  1. Start a new amber project
  2. Generate a scaffold with at least one field
  3. POST it without params

Expected behavior: 400 Bad Request

Actual behavior: 500 Internal Server Error

Reproduces how often: always

Versions

v0.7.2 and master

Additional Information

I think @faustinoaq is ready to fix this.

@faustinoaq
Copy link
Contributor

@c910335 Thank you for helping me to open issues, very appreciated! 👍 🎉

@faustinoaq
Copy link
Contributor

Fixed by #864

@faustinoaq
Copy link
Contributor

#864 is not merged yet, still work in progress 😅

@drujensen
Copy link
Member

This is now fixed. The exceptions page shows and its a 500 error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants