update config files to jsonnet format (#1479)

* update config files to jsonnet format

* rename json -> jsonnet

Author: joelgrus

allennlp/tests/common/params_test.py

@@ -192,12 +192,20 @@ def test_env_var_substitution(self):
     def test_known_configs(self):
         configs = os.listdir(self.PROJECT_ROOT / "training_config")
 
+        # Our configs use environment variable substitution, and the _jsonnet parser
+        # will fail if we don't pass it correct environment variables.
         forced_variables = [
             # constituency parser
             'PTB_TRAIN_PATH', 'PTB_DEV_PATH', 'PTB_TEST_PATH',
 
             # srl_elmo_5.5B
-            'SRL_TRAIN_DATA_PATH', 'SRL_VALIDATION_DATA_PATH'
+            'SRL_TRAIN_DATA_PATH', 'SRL_VALIDATION_DATA_PATH',
+
+            # coref
+            'COREF_TRAIN_DATA_PATH', 'COREF_DEV_DATA_PATH', 'COREF_TEST_DATA_PATH',
+
+            # ner
+            'NER_TRAIN_DATA_PATH', 'NER_TEST_A_PATH', 'NER_TEST_B_PATH'
         ]
 
         for var in forced_variables:

training_config/constituency_parser.json renamed to training_config/constituency_parser.jsonnet

@@ -12,9 +12,9 @@
     },
     "max_span_width": 10
   },
-  "train_data_path":"${COREF_TRAIN_DATA_PATH}",
-  "validation_data_path": "${COREF_DEV_DATA_PATH}",
-  "test_data_path": "${COREF_TEST_DATA_PATH}",
+  "train_data_path": std.extVar("COREF_TRAIN_DATA_PATH"),
+  "validation_data_path": std.extVar("COREF_DEV_DATA_PATH"),
+  "test_data_path": std.extVar("COREF_TEST_DATA_PATH"),
   "model": {
     "type": "coref",
     "text_field_embedder": {

training_config/coref.json renamed to training_config/coref.jsonnet

@@ -16,9 +16,9 @@
      }
     }
   },
-  "train_data_path": "${NER_TRAIN_DATA_PATH}",
-  "validation_data_path": "${NER_TEST_A_PATH}",
-  "test_data_path": "${NER_TEST_B_PATH}",
+  "train_data_path": std.extVar("NER_TRAIN_DATA_PATH"),
+  "validation_data_path": std.extVar("NER_TEST_A_PATH"),
+  "test_data_path": std.extVar("NER_TEST_B_PATH"),
   "evaluate_on_test": true,
   "model": {
     "type": "crf_tagger",

training_config/ner.json renamed to training_config/ner.jsonnet

@@ -1,7 +1,7 @@
 {
   "dataset_reader":{"type":"srl"},
-  "train_data_path": "${SRL_TRAIN_DATA_PATH}",
-  "validation_data_path": "${SRL_VALIDATION_DATA_PATH}",
+  "train_data_path": std.extVar("SRL_TRAIN_DATA_PATH"),
+  "validation_data_path": std.extVar("SRL_VALIDATION_DATA_PATH"),
   "model": {
     "type": "srl",
     "text_field_embedder": {