Skip to content

feat: support adding people with mentions #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2019
Merged

feat: support adding people with mentions #36

merged 3 commits into from
Jan 15, 2019

Conversation

sinchang
Copy link
Contributor

closes #26

@codecov
Copy link

codecov bot commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   57.95%   57.95%           
=======================================
  Files           4        4           
  Lines          88       88           
  Branches       10       10           
=======================================
  Hits           51       51           
  Misses         32       32           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f104a0a...590b6a1. Read the comment docs.

jakebolam
jakebolam reviewed Jan 15, 2019
View reviewed changes
jakebolam
jakebolam approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@jakebolam jakebolam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinchang! Looks good to me

jakebolam
jakebolam reviewed Jan 15, 2019
View reviewed changes
@jakebolam
Copy link
Contributor

@sinchang let me know when good to merge

@sinchang
Copy link
Contributor Author

@jakebolam you can merge now. 😄

jakebolam
jakebolam reviewed Jan 15, 2019
View reviewed changes
src/utils/parse-comment/index.js
@@ -75,6 +75,8 @@ function parseAddComment(doc, action) {
})
.data()[0].text

const who = whoMatched.startsWith('@') ? whoMatched.substr(1) : whoMatched
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@jakebolam
Copy link
Contributor

Thank you!

@jakebolam jakebolam merged commit 5f79140 into all-contributors:master Jan 15, 2019
@sinchang sinchang deleted the patch-2 branch January 15, 2019 15:34
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hertzg hertzg mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebolam jakebolam jakebolam approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support adding people with mentions
3 participants
@sinchang @jakebolam @all-contributors-release-bot