fix: use what the docs say for nodejs

Author: jakebolam

src/utils/Analytics.js

@@ -1,6 +1,5 @@
 const uuid = require('uuid')
 const nodeFetch = require('node-fetch')
-const { URLSearchParams } = require('url')
 
 class Analytics {
     constructor({
@@ -38,28 +37,30 @@ class Analytics {
             },
         }
 
-        const events = [
-            // TODO batch up to 10 events at a time
-            event,
-        ]
+        const inputBody = {
+            api_key: this.apiKey,
+            events: [
+                // TODO batch up to 10 events at a time
+                event,
+            ],
+        }
 
         const log = this.log
-
-        const params = new URLSearchParams()
-        params.append('api_key', this.apiKey)
-        params.append('event', JSON.stringify(events))
-
-        const newEventPromise = nodeFetch('https://api.amplitude.com/httpapi', {
+        const newEventPromise = nodeFetch('https://api.amplitude.com/batch', {
             method: 'POST',
-            body: params,
+            body: inputBody,
+            headers: {
+                'Content-Type': 'application/json',
+                Accept: '*/*',
+            },
             timeout: 5000,
             redirect: 'error',
             follow: 0,
         })
             .then(response => {
                 if (!response.ok) {
                     log.error(response)
-                    log.error(response.text())
+                    log.error(response.json())
                 }
                 return response
             })

test/utils/Analytics.test.js

@@ -4,16 +4,20 @@ const Analytics = require('../../src/utils/Analytics')
 
 describe('Analytics', () => {
     test('Analytics', async () => {
+        const mockFn = jest.fn()
         const analytics = new Analytics({
             repo: 'all-contributors-bot',
             owner: 'all-contributors',
             user: 'mockusername',
             apiKey: 'mock api key',
             funnelId: 'mockFunnelId',
+            log: {
+                error: mockFn,
+            },
         })
 
         nock('https://api.amplitude.com')
-            .post(`/httpapi`, body => {
+            .post(`/batch`, body => {
                 expect(body).toMatchSnapshot()
                 return true
             })
@@ -22,5 +26,7 @@ describe('Analytics', () => {
         analytics.track('my-event')
 
         await analytics.finishQueue()
+
+        expect(mockFn).not.toBeCalled()
     })
 })

test/utils/__snapshots__/Analytics.test.js.snap

@@ -1,8 +1,3 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Analytics Analytics 1`] = `
-Object {
-  "api_key": "mock api key",
-  "event": "[{\\"user_id\\":\\"mockusername\\",\\"event_type\\":\\"my-event\\",\\"user_properties\\":{\\"repo\\":\\"all-contributors-bot\\",\\"owner\\":\\"all-contributors\\"},\\"event_properties\\":{\\"funnel_id\\":\\"mockFunnelId\\"}}]",
-}
-`;
+exports[`Analytics Analytics 1`] = `"[object Object]"`;