Skip to content

Commit 5a63faf

Browse files
siyuan0322siyuan0322
authored
upload log should not fail the CI (#2879)
1 parent 559b084 commit 5a63faf

File tree

4 files changed

+21
-128
lines changed

4 files changed

+21
-128
lines changed

‎.github/workflows/gaia.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ jobs:
101101
- name: Upload GIE log
102102
if: failure()
103103
uses: actions/upload-artifact@v3
104+
continue-on-error: true
104105
with:
105106
name: gie-log
106107
path: /var/log/graphscope

‎.github/workflows/gss.yml

Lines changed: 6 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,7 @@ jobs:
184184
185185
minikube image load ${{ env.GSS_IMAGE }}:${SHORT_SHA}
186186
187-
- name: Start to export kubernetes logs
188-
uses: dashanji/kubernetes-log-export-action@v4
187+
- uses: dashanji/kubernetes-log-export-action@v4
189188
env:
190189
SHOW_TIMESTAMPS: 'true'
191190
OUTPUT_DIR: ${{ github.workspace }}/helm-installation-logs
@@ -203,19 +202,6 @@ jobs:
203202
helm install ci --set image.tag=${SHORT_SHA} ./graphscope-store
204203
helm test ci --timeout 5m0s
205204
206-
- name: Stop to export kubernetes logs
207-
uses: dashanji/kubernetes-log-export-action@v4
208-
env:
209-
MODE: stop
210-
211-
- name: Start to export kubernetes logs
212-
uses: dashanji/kubernetes-log-export-action@v4
213-
env:
214-
SHOW_TIMESTAMPS: 'true'
215-
OUTPUT_DIR: ${{ github.workspace }}/demo-fresh-of-helm-installation-logs
216-
NAMESPACES: "gs*,default"
217-
MODE: start
218-
219205
- name: Test the helm deployment
220206
run: |
221207
# 1. get gss service endpoint
@@ -248,19 +234,6 @@ jobs:
248234
python3 setup.py build_proto
249235
python3 -m pytest -s -vvv graphscope/tests/kubernetes/test_store_service.py -k test_demo_fresh
250236
251-
- name: Stop to export kubernetes logs
252-
uses: dashanji/kubernetes-log-export-action@v4
253-
env:
254-
MODE: stop
255-
256-
- name: Start to export kubernetes logs
257-
uses: dashanji/kubernetes-log-export-action@v4
258-
env:
259-
SHOW_TIMESTAMPS: 'true'
260-
OUTPUT_DIR: ${{ github.workspace }}/demo-script-of-helm-installation-with-pv-logs
261-
NAMESPACES: "gs*,default"
262-
MODE: start
263-
264237
- name: restart helm and run demo with the PersistentVolume
265238
run: |
266239
# restart helm and run demo with the PersistentVolume
@@ -269,19 +242,6 @@ jobs:
269242
cd ${GITHUB_WORKSPACE}/charts
270243
helm install ci --set image.tag=${SHORT_SHA} ./graphscope-store
271244
272-
- name: Stop to export kubernetes logs
273-
uses: dashanji/kubernetes-log-export-action@v4
274-
env:
275-
MODE: stop
276-
277-
- name: Start to export kubernetes logs
278-
uses: dashanji/kubernetes-log-export-action@v4
279-
env:
280-
SHOW_TIMESTAMPS: 'true'
281-
OUTPUT_DIR: ${{ github.workspace }}/helm-test-of-helm-installation-with-pv-logs
282-
NAMESPACES: "gs*,default"
283-
MODE: start
284-
285245
- name: Helm Test with Helm Deployment and PersistentVolume
286246
run: |
287247
# helm test and python test on the restarted store
@@ -290,19 +250,6 @@ jobs:
290250
export NODE_IP=$(kubectl get nodes --namespace default -o jsonpath="{.items[0].status.addresses[0].address}")
291251
helm test ci --timeout 10m0s
292252
293-
- name: Stop to export kubernetes logs
294-
uses: dashanji/kubernetes-log-export-action@v4
295-
env:
296-
MODE: stop
297-
298-
- name: Start to export kubernetes logs
299-
uses: dashanji/kubernetes-log-export-action@v4
300-
env:
301-
SHOW_TIMESTAMPS: 'true'
302-
OUTPUT_DIR: ${{ github.workspace }}/demo-after-restart-of-helm-installation-with-pv-logs
303-
NAMESPACES: "gs*,default"
304-
MODE: start
305-
306253
- name: Python Test with Helm Deployment and PersistentVolume
307254
run: |
308255
export GRPC_PORT=$(kubectl get --namespace default -o jsonpath="{.spec.ports[0].nodePort}" services ci-graphscope-store-frontend)
@@ -311,14 +258,15 @@ jobs:
311258
cd ${GITHUB_WORKSPACE}/python
312259
python3 -m pytest -s -vvv graphscope/tests/kubernetes/test_store_service.py -k test_demo_after_restart
313260
261+
- uses: dashanji/kubernetes-log-export-action@v4
262+
env:
263+
MODE: stop
264+
314265
- name: upload the k8s logs to artifact
315266
if: ${{ always() }}
316267
uses: actions/upload-artifact@v3
268+
continue-on-error: true
317269
with:
318270
name: k8s-test-logs
319271
path: ${{ github.workspace }}/k8s-ci-*-logs
320272

321-
- name: Stop to export kubernetes logs
322-
uses: dashanji/kubernetes-log-export-action@v4
323-
env:
324-
MODE: stop

‎.github/workflows/k8s-ci.yml

Lines changed: 13 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -377,23 +377,6 @@ jobs:
377377
# Use a dummy builder image (tag=ci, which is actually a busybox) to reduce time and space to pull the builder
378378
make graphscope CI=true VERSION=${SHORT_SHA} REGISTRY=registry-vpc.cn-hongkong.aliyuncs.com BUILDER_VERSION=ci
379379
380-
- name: Prepare the log directory
381-
run: |
382-
# create the helm installation log directory
383-
mkdir -p ${{ github.workspace }}/helm-installation-logs
384-
385-
# create the store service of helm installation log directory
386-
mkdir -p ${{ github.workspace }}/store-service-of-helm-installation-logs
387-
388-
# create the demo script of helm installation log directory
389-
mkdir -p ${{ github.workspace }}/demo-script-of-helm-installation-logs
390-
391-
# create the store service of kubernetes test log directory
392-
mkdir -p ${{ github.workspace }}/store-service-of-kubernetes-test-logs
393-
394-
# create the demo script of hdfs test log directory
395-
mkdir -p ${{ github.workspace }}/demo-script-of-hdfs-test-logs
396-
397380
- name: Install Python dependencies
398381
run: |
399382
cd ${GITHUB_WORKSPACE}/python
@@ -448,8 +431,7 @@ jobs:
448431
minikube image load graphscope/learning:${SHORT_SHA}
449432
echo "loaded learning"
450433
451-
- name: Start to export kubernetes logs
452-
uses: dashanji/kubernetes-log-export-action@v4
434+
- uses: dashanji/kubernetes-log-export-action@v4
453435
env:
454436
SHOW_TIMESTAMPS: 'true'
455437
OUTPUT_DIR: ${{ github.workspace }}/k8s-ci-helm-installation-logs
@@ -467,19 +449,6 @@ jobs:
467449
./graphscope
468450
helm test graphscope --timeout 5m0s
469451
470-
- name: Stop to export kubernetes logs
471-
uses: dashanji/kubernetes-log-export-action@v4
472-
env:
473-
MODE: stop
474-
475-
- name: Start to export kubernetes logs
476-
uses: dashanji/kubernetes-log-export-action@v4
477-
env:
478-
SHOW_TIMESTAMPS: 'true'
479-
OUTPUT_DIR: ${{ github.workspace }}/k8s-ci-demo-script-of-helm-installation-logs
480-
NAMESPACES: "gs*,default"
481-
MODE: start
482-
483452
- name: Test demo script of helm installation
484453
run: |
485454
export NODE_IP=$(kubectl get pod -lgraphscope.coordinator.name=coordinator-graphscope -ojsonpath="{.items[0].status.hostIP}")
@@ -490,20 +459,17 @@ jobs:
490459
491460
python3 -m pytest -s -vvv ./graphscope/tests/kubernetes/test_demo_script.py -k test_helm_installation
492461
493-
- name: Stop to export kubernetes logs
494-
uses: dashanji/kubernetes-log-export-action@v4
462+
- uses: dashanji/kubernetes-log-export-action@v4
495463
env:
496464
MODE: stop
497465

498466
- name: Delete Helm Cluster
499-
run: |
500-
helm delete graphscope
467+
run: helm delete graphscope
501468

502-
- name: Start to export kubernetes logs
503-
uses: dashanji/kubernetes-log-export-action@v4
469+
- uses: dashanji/kubernetes-log-export-action@v4
504470
env:
505471
SHOW_TIMESTAMPS: 'true'
506-
OUTPUT_DIR: ${{ github.workspace }}/k8s-ci-store-service-of-kubernetes-test-logs
472+
OUTPUT_DIR: ${{ github.workspace }}/k8s-ci-demo-script-test-logs
507473
NAMESPACES: "gs*,default"
508474
MODE: start
509475

@@ -522,25 +488,12 @@ jobs:
522488
--cov-report=term --exitfirst -s -vvv --log-cli-level=INFO \
523489
./graphscope/tests/kubernetes
524490
525-
- name: Stop to export kubernetes logs
526-
uses: dashanji/kubernetes-log-export-action@v4
527-
env:
528-
MODE: stop
529-
530491
- name: Upload Coverage
531492
uses: codecov/codecov-action@v3
532493
with:
533494
file: ./python/coverage.xml
534495
fail_ci_if_error: false
535496

536-
- name: Start to export kubernetes logs
537-
uses: dashanji/kubernetes-log-export-action@v4
538-
env:
539-
SHOW_TIMESTAMPS: 'true'
540-
OUTPUT_DIR: ${{ github.workspace }}/k8s-ci-demo-script-of-hdfs-test-logs
541-
NAMESPACES: "gs*,default"
542-
MODE: start
543-
544497
- name: HDFS test
545498
env:
546499
JAVA_HOME: /usr/lib/jvm/default-java
@@ -561,28 +514,24 @@ jobs:
561514
hadoop fs -put ${GS_TEST_DIR}/ldbc_sample/person_0_0.csv /ldbc_sample/person_0_0.csv
562515
hadoop fs -put ${GS_TEST_DIR}/ldbc_sample/person_knows_person_0_0.csv /ldbc_sample/person_knows_person_0_0.csv
563516
564-
# validate hadoop
565-
hadoop fs -ls /ldbc_sample
566-
567517
# prepare CI environments
568518
export HDFS_TEST_DIR=hdfs:///ldbc_sample
569519
export HDFS_HOST=$(hostname -I | awk '{print $1}')
570520
571521
# run test
572522
cd ${GITHUB_WORKSPACE}/python
573-
574523
python3 -m pytest -s -vvv ./graphscope/tests/kubernetes/test_demo_script.py -k test_demo_on_hdfs
575524
# Check the result file have successfully written to the given location
576525
# hdfs dfs -test -e /ldbc_sample/res.csv_0 && hdfs dfs -test -e /ldbc_sample/res.csv_1
577526
578-
- name: Stop to export kubernetes logs
579-
uses: dashanji/kubernetes-log-export-action@v4
527+
- uses: dashanji/kubernetes-log-export-action@v4
580528
env:
581529
MODE: stop
582530

583531
- name: Upload the k8s logs to artifact
584532
uses: actions/upload-artifact@v3
585533
if: ${{ always() }}
534+
continue-on-error: true
586535
with:
587536
name: k8s-test-logs
588537
path: ${{ github.workspace }}/k8s-ci-*-logs
@@ -718,11 +667,6 @@ jobs:
718667
-t registry.cn-hongkong.aliyuncs.com/graphscope/interactive-experimental:${SHORT_SHA} \
719668
-f .github/workflows/docker/interactive-experimental-local-artifacts.Dockerfile .
720669
721-
- name: Prepare the log directory
722-
run: |
723-
# create the k8s failover test log directory
724-
mkdir -p ${{ github.workspace }}/k8s-failover-test-logs
725-
726670
- name: Prepare Cluster and Data
727671
env:
728672
GS_TEST_DIR: ${{ github.workspace }}/gstest
@@ -743,8 +687,7 @@ jobs:
743687
# install python gremlin client
744688
pip install gremlinpython
745689
746-
- name: Start to export kubernetes logs
747-
uses: dashanji/kubernetes-log-export-action@v4
690+
- uses: dashanji/kubernetes-log-export-action@v4
748691
env:
749692
SHOW_TIMESTAMPS: 'true'
750693
OUTPUT_DIR: ${{ github.workspace }}/k8s-failover-logs
@@ -769,14 +712,14 @@ jobs:
769712
# run failover test
770713
cd ${GITHUB_WORKSPACE}/interactive_engine/compiler && ./ir_k8s_failover_ci.sh default test-gie-standalone 2 1
771714
715+
- uses: dashanji/kubernetes-log-export-action@v4
716+
env:
717+
MODE: stop
718+
772719
- name: upload the k8s logs to artifact
773720
uses: actions/upload-artifact@v3
721+
continue-on-error: true
774722
if: ${{ always() }}
775723
with:
776724
name: k8s-failover-logs
777725
path: ${{ github.workspace }}/k8s-failover-logs
778-
779-
- name: Stop to export kubernetes logs
780-
uses: dashanji/kubernetes-log-export-action@v4
781-
env:
782-
MODE: stop

‎.github/workflows/local-ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@ jobs:
313313
- name: Upload GIE log
314314
if: failure()
315315
uses: actions/upload-artifact@v3
316+
continue-on-error: true
316317
with:
317318
name: gie-log
318319
path: ~/.local/log/graphscope

0 commit comments

Comments
 (0)