Skip to content

dev app should use a different price facet for priceRanges widget #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
vvo opened this issue Oct 22, 2015 · 3 comments
Closed
3 tasks

dev app should use a different price facet for priceRanges widget #327

vvo opened this issue Oct 22, 2015 · 3 comments
Milestone

Comments

@vvo
Copy link
Contributor

vvo commented Oct 22, 2015

Both the slider and priceRanges widget are using the same facetName, thus the behavior of both widgets is weird: slider limit is updated dynamically when you use it.

TODO:

  • modify the import script of the instant search index to add priceForPriceRanges
  • regenerate the indec
  • use this new attribute in our dev app
@vvo vvo added the chore label Oct 22, 2015
@vvo vvo added this to the 1.0.0 milestone Oct 22, 2015
@redox
Copy link
Contributor

redox commented Nov 3, 2015

I think we'll anyway not manage to have all the widgets working at the same time in the future with this dataset. I would just move to another randomly-generated dataset with plenty of numerical/facets to handle it easier for the dev.

@bobylito
Copy link
Contributor

bobylito commented Nov 4, 2015

I think all the widgets should be able to live on the same page.

@vvo
Copy link
Contributor Author

vvo commented Nov 4, 2015

I think all the widgets should be able to live on the same page.

Yes me too but for this particular one (priceRange and rangeSlider, on the same attribute), the result will always be weird. Given that priceRange has a specific behavior that breaks the slider.

Having a slider and priceRange on different attribute is fine of course.

Was that your question @bobylito?

@vvo vvo closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants