Skip to content

Commit 5260d1e

Browse files
authored
fix(hits): default to hierarchy lvl0 if highlights present (#2309)
1 parent 9733ba9 commit 5260d1e

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

examples/demo/src/App.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ function App() {
99
<div>
1010
<h1>DocSearch v3 - React</h1>
1111
<DocSearch
12-
indexName="docsearch"
13-
appId="R2IYF7ETH7"
14-
apiKey="599cec31baffa4868cae4e79f180729b"
12+
indexName="vuejs"
13+
appId="ML0LEBN7FQ"
14+
apiKey="21cf9df0734770a2448a9da64a700c22"
1515
insights
1616
/>
1717
</div>

packages/docsearch-react/src/utils/removeHighlightTags.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,15 @@ export function removeHighlightTags(
1212
return hit.hierarchy.lvl0;
1313
}
1414

15-
const { value } =
16-
(internalDocSearchHit.__docsearch_parent
17-
? internalDocSearchHit.__docsearch_parent?._highlightResult?.hierarchy
18-
?.lvl0
19-
: hit._highlightResult?.hierarchy?.lvl0) || {};
15+
const lvl0 = internalDocSearchHit.__docsearch_parent
16+
? internalDocSearchHit.__docsearch_parent?._highlightResult?.hierarchy?.lvl0
17+
: hit._highlightResult?.hierarchy?.lvl0;
2018

21-
return value && regexHasHighlightTags.test(value)
22-
? value.replace(regexHighlightTags, '')
23-
: value;
19+
if (!lvl0) {
20+
return hit.hierarchy.lvl0;
21+
}
22+
23+
return lvl0.value && regexHasHighlightTags.test(lvl0.value)
24+
? lvl0.value.replace(regexHighlightTags, '')
25+
: lvl0.value;
2426
}

0 commit comments

Comments
 (0)