Skip to content

Commit c6a29a0

Browse files
Add quiet parameter to be able to show pip output (bazel-contrib#42)
1 parent 8b3f2d5 commit c6a29a0

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

defs.bzl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def _pip_repository_impl(rctx):
88
target = rctx.attr.python_interpreter_target
99
python_interpreter = rctx.path(target)
1010
else:
11-
if '/' not in python_interpreter:
11+
if "/" not in python_interpreter:
1212
python_interpreter = rctx.which(python_interpreter)
1313
if not python_interpreter:
1414
fail("python interpreter not found")
@@ -41,6 +41,7 @@ def _pip_repository_impl(rctx):
4141
"PYTHONPATH": pypath,
4242
},
4343
timeout = rctx.attr.timeout,
44+
quiet = rctx.attr.quiet,
4445
)
4546
if result.return_code:
4647
fail("rules_python_external failed: %s (%s)" % (result.stdout, result.stderr))
@@ -60,6 +61,7 @@ python_interpreter.
6061
"""),
6162
# 600 is documented as default here: https://docs.bazel.build/versions/master/skylark/lib/repository_ctx.html#execute
6263
"timeout": attr.int(default = 600),
64+
"quiet": attr.bool(default = True),
6365
},
6466
implementation = _pip_repository_impl,
6567
)

extract_wheels/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def main() -> None:
6767

6868
pip_args = [sys.executable, "-m", "pip", "wheel", "-r", args.requirements]
6969
# Assumes any errors are logged by pip so do nothing. This command will fail if pip fails
70-
subprocess.check_output(pip_args)
70+
subprocess.run(pip_args, check=True)
7171

7272
extras = requirements.parse_extras(args.requirements)
7373

0 commit comments

Comments
 (0)