Skip to content

Commit aa8996f

Browse files
committed
Bump terraform-aws-alb-target-group-cloudwatch-sns-alarms module to 0.8.0
1 parent 03dca4b commit aa8996f

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

main.tf

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ module "ecs_instance_label" {
120120
name = var.name
121121
namespace = var.namespace
122122
stage = var.stage
123-
tags = merge({
123+
tags = merge({
124124
"Cluster" = module.ecs.this_ecs_cluster_name
125125
}, var.tags)
126126
}
@@ -339,7 +339,7 @@ data "aws_alb_target_group" "default" {
339339
module "alb_target_group_alarms" {
340340
enabled = var.alb_target_group_alarms_enabled
341341

342-
source = "git::https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms.git?ref=tags/0.7.0"
342+
source = "git::https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms.git?ref=tags/0.8.0"
343343
attributes = var.attributes
344344
delimiter = var.delimiter
345345
name = var.name
@@ -356,15 +356,9 @@ module "alb_target_group_alarms" {
356356
period = var.alb_target_group_alarms_period
357357
evaluation_periods = var.alb_target_group_alarms_evaluation_periods
358358

359-
# https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms/pull/18
360-
ok_actions = [aws_sns_topic.default.arn]
361-
alarm_actions = [aws_sns_topic.default.arn]
362-
insufficient_data_actions = [aws_sns_topic.default.arn]
363-
notify_arns = [aws_sns_topic.default.arn]
364-
}
365-
366-
resource "aws_sns_topic" "default" {
367-
name = "test"
359+
ok_actions = var.alb_target_group_alarms_ok_actions
360+
alarm_actions = var.alb_target_group_alarms_alarm_actions
361+
insufficient_data_actions = var.alb_target_group_alarms_insufficient_data_actions
368362
}
369363

370364
#############################################################

variables.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -562,19 +562,19 @@ variable "alb_target_group_alarms_evaluation_periods" {
562562
variable "alb_target_group_alarms_alarm_actions" {
563563
type = list(string)
564564
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when ALB Target Group alarms transition into an ALARM state from any other state"
565-
default = [""]
565+
default = []
566566
}
567567

568568
variable "alb_target_group_alarms_ok_actions" {
569569
type = list(string)
570570
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when ALB Target Group alarms transition into an OK state from any other state"
571-
default = [""]
571+
default = []
572572
}
573573

574574
variable "alb_target_group_alarms_insufficient_data_actions" {
575575
type = list(string)
576576
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when ALB Target Group alarms transition into an INSUFFICIENT_DATA state from any other state"
577-
default = [""]
577+
default = []
578578
}
579579

580580
variable "traefik_launch_type" {

0 commit comments

Comments
 (0)