Skip to content

Commit 9ab59e3

Browse files
authored
Merge pull request #159 from cristian64/adjust_memory_viewer_font_size
Use correct font in painter in **Memory Viewer** dialog.
2 parents 82e1314 + ff6308f commit 9ab59e3

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

Source/GUI/MemViewer/MemViewer.cpp

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ MemViewer::~MemViewer()
4949

5050
void MemViewer::initialise()
5151
{
52-
updateFontSize(m_memoryFontSize);
52+
updateFontSize();
5353
m_curosrRect = new QRect();
5454
m_updatedRawMemoryData = new char[m_numCells];
5555
m_lastRawMemoryData = new char[m_numCells];
@@ -356,9 +356,14 @@ void MemViewer::wheelEvent(QWheelEvent* event)
356356
if (event->modifiers().testFlag(Qt::ControlModifier))
357357
{
358358
if (event->angleDelta().y() < 0 && m_memoryFontSize > 5)
359-
updateFontSize(m_memoryFontSize - 1);
359+
{
360+
m_memoryFontSize -= 1;
361+
}
360362
else if (event->angleDelta().y() > 0)
361-
updateFontSize(m_memoryFontSize + 1);
363+
{
364+
m_memoryFontSize += 1;
365+
}
366+
updateFontSize();
362367

363368
viewport()->update();
364369
}
@@ -368,19 +373,16 @@ void MemViewer::wheelEvent(QWheelEvent* event)
368373
}
369374
}
370375

371-
void MemViewer::updateFontSize(int newSize)
376+
void MemViewer::updateFontSize()
372377
{
373-
m_memoryFontSize = newSize;
378+
if (m_memoryFontSize == -1)
379+
{
380+
m_memoryFontSize = static_cast<int>(font().pointSize() * 1.5);
381+
}
374382

375-
#ifdef __linux__
376-
setFont(QFont("Monospace", m_memoryFontSize));
377-
#elif _WIN32
378-
setFont(QFont("Courier New", m_memoryFontSize));
379-
#elif __APPLE__
380383
QFont fixedFont = QFontDatabase::systemFont(QFontDatabase::FixedFont);
381384
fixedFont.setPointSize(m_memoryFontSize);
382385
setFont(fixedFont);
383-
#endif
384386

385387
m_charWidthEm = fontMetrics().horizontalAdvance(QLatin1Char('M'));
386388
m_charHeight = fontMetrics().height();
@@ -1013,6 +1015,7 @@ void MemViewer::paintEvent(QPaintEvent* event)
10131015
(void)event;
10141016

10151017
QPainter painter(viewport());
1018+
painter.setFont(font());
10161019
painter.setPen(QColor(Qt::black));
10171020

10181021
renderSeparatorLines(painter);

Source/GUI/MemViewer/MemViewer.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class MemViewer : public QAbstractScrollArea
6767

6868
void initialise();
6969

70-
void updateFontSize(int newSize);
70+
void updateFontSize();
7171
bytePosFromMouse mousePosToBytePos(QPoint pos);
7272
void scrollToSelection();
7373
void copySelection(Common::MemType type) const;
@@ -93,7 +93,7 @@ class MemViewer : public QAbstractScrollArea
9393
const int m_numRows = 16;
9494
const int m_numColumns = 16; // Should be a multiple of 16, or the header doesn't make much sense
9595
const int m_numCells = m_numRows * m_numColumns;
96-
int m_memoryFontSize = 15;
96+
int m_memoryFontSize = -1;
9797
int m_StartBytesSelectionPosX = 0;
9898
int m_StartBytesSelectionPosY = 0;
9999
int m_EndBytesSelectionPosX = 0;

0 commit comments

Comments
 (0)