-
Notifications
You must be signed in to change notification settings - Fork 86
Implement "any_chip" argument #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can pick this up over the weekend if it's not already done yet? |
That would be amazing @subash774 ! I didn't manage to find any time to do this in the end, so if you could, that would be great! Don't hesitate to ask if you have any questions.. |
Changing the model from dict to a data class would be good, I'll get the PR out first and then we can think about cleaning those up, will help with typing and scalability |
@nbarlowATI |
Hey @subash774 , thanks for looking at this! I think one option is that if chip_gameweeks = {
"wildcard": 24,
"free_hit": 24,
"triple_captain": 24,
"bench_boost": 24,
} Which would then require the I don't think this would require any changes to |
As described in #692 , we sometimes have a situation where we know we want to play one of our chips, but it's not clear whether e.g. a triple_captain or a bench_boost would be more effective.
We can run with all chip gameweek arguments set to "0", but that will be a prohibitive number of possible combinations.
Instead, we can implement "--any_chip_week", and it will try all available chips for that gameweek.
The implementation would mostly be in
airsenal/scripts/fill_transfersuggestion_table.py
. The argument should be added to the argparse args. Thismain
function also then creates a dict "chip_gameweeks", which is used inconstruct_chip_dict
- I think that will be the key function to modify. Hopefully the resultingchip_gw_dict
will be used both in the optimization itself and in the calculation of the number of expected outputs...The text was updated successfully, but these errors were encountered: