Skip to content

[PERF] Backoff Supervisor uses Expression based Props #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
to11mtm opened this issue Jun 19, 2023 · 0 comments · Fixed by #6821
Closed

[PERF] Backoff Supervisor uses Expression based Props #6804

to11mtm opened this issue Jun 19, 2023 · 0 comments · Fixed by #6821
Assignees
Labels

Comments

@to11mtm
Copy link
Member

to11mtm commented Jun 19, 2023

Related to #4698

Version Information
1.4.x

Describe the performance issue
Backoff Supervisor Props use Expressions, which has a large perf impact for cases where an actor is created semi-transiently but still needs backoff.

Data and Specs
See #4698 for details. The benchmarks there illustrate the overall concern well enough.

Expected behavior
Don't use Expression based props where it's possible transient actors are being created.

Actual behavior
We use expression based props and it hurts perf by a significant margian

Environment
N/A

Additional context
This is not as big a problem for long lived actors.

We should still consider having an issue for other internals of akka where this may come up, even if it means more diligence from maintainers (although, FWIW, unit tests should cover when someone gets it wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant