remove ActorPath.ToString call from ResolveActorRefWithLocalAddress (#5034)

Aaronontheweb · web-flow · commit 6f5b003dce9d · 2021-05-24T20:04:39.000Z
* remove `ActorPath.ToString` call from `ResolveActorRefWithLocalAddress`

* remove comment
diff --git a/src/core/Akka.Remote/RemoteActorRefProvider.cs b/src/core/Akka.Remote/RemoteActorRefProvider.cs
@@ -489,8 +489,7 @@ public IInternalActorRef ResolveActorRefWithLocalAddress(string path, Address lo
                 //the actor's local address was already included in the ActorPath
                 if (HasAddress(actorPath.Address))
                 {
-                    // HACK: needed to make ActorSelections work
-                    if (actorPath.ToStringWithoutAddress().Equals("/"))
+                    if (actorPath is RootActorPath)
                         return RootGuardian;
                     return _local.ResolveActorRef(RootGuardian, actorPath.ElementsWithUid);
                 }

Original file line number	Diff line number	Diff line change
`@@ -489,8 +489,7 @@ public IInternalActorRef ResolveActorRefWithLocalAddress(string path, Address lo`
`489`	`489`	`//the actor's local address was already included in the ActorPath`
`490`	`490`	`if (HasAddress(actorPath.Address))`
`491`	`491`	`{`
`492`		`- // HACK: needed to make ActorSelections work`
`493`		`- if (actorPath.ToStringWithoutAddress().Equals("/"))`
	`492`	`+ if (actorPath is RootActorPath)`
`494`	`493`	`return RootGuardian;`
`495`	`494`	`return _local.ResolveActorRef(RootGuardian, actorPath.ElementsWithUid);`
`496`	`495`	`}`