[obsolete][CS0618][CS0672] Disassociate #pragma warning disable

Author: eaba

src/core/Akka.Remote/EndpointManager.cs

@@ -791,7 +791,9 @@ bool MatchesQuarantine(AkkaProtocolHandle handle)
                     // Side-effecting here
                     if (drop)
                     {
+#pragma warning disable CS0618
                         x.Value.Disassociate();
+#pragma warning restore CS0618
                         Context.Stop(x.Key);
                     }
                     return !drop;
@@ -805,7 +807,9 @@ bool MatchesQuarantine(AkkaProtocolHandle handle)
                         var handle = assoc.Association.AsInstanceOf<AkkaProtocolHandle>();
                         var drop = MatchesQuarantine(handle);
                         if (drop)
+#pragma warning disable CS0618
                             handle.Disassociate();
+#pragma warning restore CS0618
                         return !drop;
                     }).ToList();
                     return new KeyValuePair<IActorRef, List<InboundAssociation>>(x.Key, associations);

src/core/Akka.Remote/Transport/DotNetty/TcpTransport.cs

@@ -184,8 +184,9 @@ private static IByteBuffer ToByteBuffer(IChannel channel, ByteString payload)
             var buffer = Unpooled.WrappedBuffer(payload.ToByteArray());
             return buffer;
         }
-
+#pragma warning disable CS0672
         public override void Disassociate()
+#pragma warning restore CS0672
         {
             _channel.CloseAsync();
         }

src/core/Akka.Remote/Transport/FailureInjectorTransportAdapter.cs

@@ -438,12 +438,17 @@ public override bool Write(ByteString payload)
         /// <summary>
         /// TBD
         /// </summary>
+
+#pragma warning disable CS0672
         public override void Disassociate()
+#pragma warning restore CS0672
         {
+#pragma warning disable CS0618
             WrappedHandle.Disassociate();
+#pragma warning restore CS0618
         }
 
-#region IHandleEventListener members
+        #region IHandleEventListener members
 
         /// <summary>
         /// TBD

src/core/Akka.Remote/Transport/TestTransport.cs

@@ -821,7 +821,9 @@ public override bool Write(ByteString payload)
         /// <summary>
         /// TBD
         /// </summary>
+#pragma warning disable CS0672
         public override void Disassociate()
+#pragma warning restore CS0672
         {
             _transport.Disassociate(this);
         }

src/core/Akka.Remote/Transport/ThrottleTransportAdapter.cs

@@ -432,26 +432,28 @@ protected override void Ready(object message)
                     foreach (var handle in _handleTable)
                     {
                         if (handle.Item1 == naked)
-                            handle.Item2.Disassociate();
-                    }
+#pragma warning disable CS0618
+                                handle.Item2.Disassociate();
+#pragma warning restore CS0618
+                        }
 
-                    /*
-                     * NOTE: Important difference between Akka.NET and Akka here.
-                     * In canonical Akka, ThrottleHandlers are never removed from
-                     * the _handleTable. The reason is because Ask-ing a terminated ActorRef
-                     * doesn't cause any exceptions to be thrown upstream - it just times out
-                     * and propagates a failed Future.
-                     * 
-                     * In the CLR, a CancellationException gets thrown and causes all
-                     * parent tasks chaining back to the EndPointManager to fail due
-                     * to an Ask timeout.
-                     * 
-                     * So in order to avoid this problem, we remove any disassociated handles
-                     * from the _handleTable.
-                     * 
-                     * Questions? Ask @Aaronontheweb
-                     */
-                    _handleTable.RemoveAll(tuple => tuple.Item1 == naked);
+                        /*
+                         * NOTE: Important difference between Akka.NET and Akka here.
+                         * In canonical Akka, ThrottleHandlers are never removed from
+                         * the _handleTable. The reason is because Ask-ing a terminated ActorRef
+                         * doesn't cause any exceptions to be thrown upstream - it just times out
+                         * and propagates a failed Future.
+                         * 
+                         * In the CLR, a CancellationException gets thrown and causes all
+                         * parent tasks chaining back to the EndPointManager to fail due
+                         * to an Ask timeout.
+                         * 
+                         * So in order to avoid this problem, we remove any disassociated handles
+                         * from the _handleTable.
+                         * 
+                         * Questions? Ask @Aaronontheweb
+                         */
+                        _handleTable.RemoveAll(tuple => tuple.Item1 == naked);
                     Sender.Tell(ForceDisassociateAck.Instance);
                     return;
                 }
@@ -927,7 +929,9 @@ bool TryConsume(ThrottleMode currentBucket)
         }
 
         /// <inheritdoc/>
+#pragma warning disable CS0672
         public override void Disassociate()
+#pragma warning restore CS0672
         {
             ThrottlerActor.Tell(PoisonPill.Instance);
         }
@@ -1162,7 +1166,9 @@ private void InitializeFSM()
                         if (mode is Blackhole)
                         {
                             ThrottledMessages = new Queue<ByteString>();
+#pragma warning disable CS0618
                             exposedHandle.Disassociate();
+#pragma warning restore CS0618
                             return Stop();
                         }
                         else