Remove FAKE F# build scripts (#395)

* Remove FAKE F# build scripts

* Re-add windows-pr-validation.yaml

* Add missing coverlet.runsettings

* Disable net FX and netcoreapp3.1 target for linux test build

* Bump test framework target to net8.0

* Drop netcoreapp3.1 test framework target

Author: Arkatufus

Hyperion.sln

@@ -7,12 +7,12 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hyperion", "src\Hyperion\Hy
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Build", "Build", "{2F3D4EC4-3A41-48C2-9DEA-0510B0FF89B4}"
 	ProjectSection(SolutionItems) = preProject
-		build.cmd = build.cmd
-		build.fsx = build.fsx
 		build.ps1 = build.ps1
-		build.sh = build.sh
 		README.md = README.md
 		RELEASE_NOTES.md = RELEASE_NOTES.md
+		global.json = global.json
+		NuGet.Config = NuGet.Config
+		src\common.props = src\common.props
 	EndProjectSection
 EndProject
 Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Hyperion.Tests.FSharpData", "src\Hyperion.Tests.FSharpData\Hyperion.Tests.FSharpData.fsproj", "{1E406A85-C7F5-4F62-9D72-88C67FF2D743}"
@@ -25,6 +25,21 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hyperion.Akka.Integration.T
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hyperion.API.Tests", "src\Hyperion.API.Tests\Hyperion.API.Tests.csproj", "{767FBBD2-869C-4AAD-ABF4-F23EC0D381AA}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "scripts", "scripts", "{CFD6961A-9F66-4BF6-AE27-EE5B5013E6B1}"
+	ProjectSection(SolutionItems) = preProject
+		scripts\bumpVersion.ps1 = scripts\bumpVersion.ps1
+		scripts\getReleaseNotes.ps1 = scripts\getReleaseNotes.ps1
+	EndProjectSection
+EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build-system", "build-system", "{A5AA04A4-1B47-40CF-BDFB-08ADB09BF647}"
+	ProjectSection(SolutionItems) = preProject
+		build-system\azure-pipeline.template.yaml = build-system\azure-pipeline.template.yaml
+		build-system\nightly-builds.yaml = build-system\nightly-builds.yaml
+		build-system\pr-validation.yaml = build-system\pr-validation.yaml
+		build-system\windows-release.yaml = build-system\windows-release.yaml
+		build-system\windows-pr-validation.yaml = build-system\windows-pr-validation.yaml
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -62,4 +77,8 @@ Global
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {B1C59E88-286D-4AD0-B5FC-94C8F95BF0FA}
 	EndGlobalSection
+	GlobalSection(NestedProjects) = preSolution
+		{CFD6961A-9F66-4BF6-AE27-EE5B5013E6B1} = {2F3D4EC4-3A41-48C2-9DEA-0510B0FF89B4}
+		{A5AA04A4-1B47-40CF-BDFB-08ADB09BF647} = {2F3D4EC4-3A41-48C2-9DEA-0510B0FF89B4}
+	EndGlobalSection
 EndGlobal

NuGet.Config

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <solution>
+    <add key="disableSourceControlIntegration" value="true" />
+  </solution>
+  <packageSources>
+    <clear />
+    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
+  </packageSources>
+</configuration>

RELEASE_NOTES.md

@@ -1,13 +1,13 @@
-### 0.12.2 March 31 2022 ####
+#### 0.12.2 March 31 2022 ####
 
 * Fix [deserialization type cache was shared between multiple serializer instances](https://github.com/akkadotnet/Hyperion/pull/306) 
 
-### 0.12.1 March 23 2022 ####
+#### 0.12.1 March 23 2022 ####
 
 * Fix disallow-unsafe-type Akka.NET settings and harden unsafe type detection [301](https://github.com/akkadotnet/Hyperion/pull/301)
 * Bump [Akka version from 1.4.34 to 1.4.35](https://github.com/akkadotnet/akka.net/releases/tag/1.4.35)
 
-### 0.12.0 January 12 2022 ####
+#### 0.12.0 January 12 2022 ####
 
 * Allow explicit control over which types can be deserialized [#281](https://github.com/akkadotnet/Hyperion/pull/281)
 
@@ -25,12 +25,12 @@ var serializer = new Serializer(options);
 
 For complete documentation, please read the [readme on filtering types for secure deserialization.](https://github.com/akkadotnet/Hyperion#whitelisting-types-on-deserialization)
 
-### 0.11.2 October 7 2021 ####
+#### 0.11.2 October 7 2021 ####
 * Fix exception thrown during deserialization when preserve object reference was turned on 
   and a surrogate instance was inserted into a collection multiple times. [#264](https://github.com/akkadotnet/Hyperion/pull/264)
 * Add support for AggregateException serialization. [#266](https://github.com/akkadotnet/Hyperion/pull/266)
 
-### 0.11.1 August 17 2021 ####
+#### 0.11.1 August 17 2021 ####
 * Add [unsafe deserialization type blacklist](https://github.com/akkadotnet/Hyperion/pull/242)
 * Bump [Akka version from 1.4.21 to 1.4.23](https://github.com/akkadotnet/Hyperion/pull/246)
 
@@ -60,7 +60,7 @@ The unsafe types that are currently blocked are:
 - System.Diagnostics.Process
 - System.Management.IWbemClassObjectFreeThreaded
 
-### 0.11.0 July 8 2021 ####
+#### 0.11.0 July 8 2021 ####
 * [Fix array of user defined structs serialization failure](https://github.com/akkadotnet/Hyperion/pull/235)
 * [Remove dynamic keyword usage from array serializer](https://github.com/akkadotnet/Hyperion/pull/139)
 * [Change field ordering to ordinal](https://github.com/akkadotnet/Hyperion/pull/236)
@@ -73,9 +73,9 @@ that are serialized using the Hyperion serializer.
 Please report any serialization problem that occurs after an upgrade to this version at the
 [issue tracker](https://github.com/akkadotnet/Hyperion/issues)
 
-### 0.10.2 June 30 2021 ####
+#### 0.10.2 June 30 2021 ####
 * [Update Akka version to 1.4.21](https://github.com/akkadotnet/akka.net/releases/tag/1.4.21)
 * [Add exception rethrow to help with debugging](https://github.com/akkadotnet/Hyperion/pull/229)
 
-### 0.10.1 April 20 2021 ####
+#### 0.10.1 April 20 2021 ####
 * [Fix SerializerOptions constructor backward compatibility issue with Akka.NET](https://github.com/akkadotnet/Hyperion/pull/214)

build-system/azure-pipeline.template.yaml

@@ -1,64 +1,108 @@
 parameters:
   name: ''
+  displayName: ''
   vmImage: ''
-  scriptFileName: ''
-  scriptArgs: 'all'
+  outputDirectory: ''
+  artifactName: ''
   timeoutInMinutes: 120
-  outputDirectory: 'bin/nuget'
 
 jobs:
   - job: ${{ parameters.name }}
+    displayName: ${{ parameters.displayName }}
     timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
+
     pool:
       vmImage: ${{ parameters.vmImage }}
+
     steps:
       - checkout: self  # self represents the repo where the initial Pipelines YAML file was found
         clean: false  # whether to fetch clean each time
         submodules: recursive  # set to 'true' for a single level of submodules or 'recursive' to get submodules of submodules
         persistCredentials: true
+
       - task: UseDotNet@2
-        displayName: 'Use .NET 5 SDK 5.0.408'
+        displayName: 'Use .NET'
         inputs:
-          version: 5.0.408
+          packageType: 'sdk'
+          useGlobalJson: true
+          
       - task: UseDotNet@2
-        displayName: 'Use .NET Core Runtime 3.1.32'
+        displayName: "Use .NET 8 runtime"
         inputs:
           packageType: runtime
-          version: 3.1.32
-      # Linux or macOS
-      - task: Bash@3 
-        displayName: Linux / OSX Build
-        inputs:
-          filePath: ${{ parameters.scriptFileName }}
-          arguments: ${{ parameters.scriptArgs }}
-        continueOnError: true
-        condition: in( variables['Agent.OS'], 'Linux', 'Darwin' )
-      # Windows
-      - task: BatchScript@1
-        displayName: Windows Build
-        inputs:
-          filename: ${{ parameters.scriptFileName }}
-          arguments: ${{ parameters.scriptArgs }}
-        continueOnError: true
-        condition: eq( variables['Agent.OS'], 'Windows_NT' )
+          version: 8.x
+      
+      - script: dotnet tool restore
+        displayName: 'Restore dotnet tools'
+
+      - pwsh: |
+          .\build.ps1
+        displayName: 'Update Release Notes'
+        continueOnError: false
+
+      - script: dotnet build -c Release
+        displayName: 'dotnet build'
+        continueOnError: false
+
+      - pwsh: |
+          Get-ChildItem `
+            -Recurse `
+            -File `
+            -Include '*.Tests.csproj' `
+            -Exclude '*examples*', '*benchmarks*' `
+          | ForEach-Object { `
+            dotnet test -c Release --no-build --logger:trx --collect:"XPlat Code Coverage" --results-directory TestResults --settings coverlet.runsettings $_.FullName `
+          }
+        displayName: 'Run tests'
+        continueOnError: true # Allow continuation even if tests fail
+
       - task: PublishTestResults@2
         inputs:
-          testRunner: VSTest
+          testResultsFormat: VSTest
           testResultsFiles: '**/*.trx' #TestResults folder usually
           testRunTitle: ${{ parameters.name }}
           mergeTestResults: true
-      - task: CopyFiles@2
-        displayName: 'Copy Build Output'
+          failTaskOnFailedTests: false
+          publishRunAttachments: true
+          
+      - pwsh: |
+          $coverageFiles = Get-ChildItem -Path "$(Build.SourcesDirectory)/TestResults" -Filter "*.cobertura.xml" -Recurse
+          $hasCoverageFiles = $coverageFiles.Count -gt 0
+          Write-Host "##vso[task.setvariable variable=HasCoverageFiles]$hasCoverageFiles"
+        displayName: 'Check for Coverage Files'
+        condition: always()
+        continueOnError: true
+
+      - task: reportgenerator@5
+        displayName: ReportGenerator
+        # Only run if coverage files exist
+        condition: and(always(), eq(variables['HasCoverageFiles'], 'True'))
+        continueOnError: true
         inputs:
-          sourceFolder: ${{ parameters.outputDirectory }}
-          contents: '**\*'
-          targetFolder: $(Build.ArtifactStagingDirectory)
-          continueOnError: boolean  # 'true' if future steps should run even if this step fails; defaults to 'false'
+          reports: '$(Build.SourcesDirectory)/TestResults/**/*.cobertura.xml'
+          targetdir: '$(Build.SourcesDirectory)/coveragereport'
+          reporttypes: 'HtmlInline_AzurePipelines;Cobertura;Badges'
+          assemblyfilters: '-xunit*'
+          publishCodeCoverageResults: true
+
+      - publish: $(Build.SourcesDirectory)/coveragereport
+        displayName: 'Publish Coverage Report'
+        # Only run if coverage files exist
+        condition: and(always(), eq(variables['HasCoverageFiles'], 'True'))
+        continueOnError: true
+        artifact: 'CoverageReports-$(Agent.OS)-$(Build.BuildId)'
+          
+      - script: dotnet pack -c Release --no-build -o $(Build.ArtifactStagingDirectory)/nuget
+        displayName: 'Create packages'
+          
       - task: PublishBuildArtifacts@1
+        displayName: 'Publish artifacts'
         inputs:
-          pathtoPublish: '$(Build.ArtifactStagingDirectory)'
-          artifactName: ${{ parameters.name }}
+          PathtoPublish: '$(Build.ArtifactStagingDirectory)/nuget'
+          ArtifactName: 'nuget'
+          publishLocation: 'Container'
+
       - script: 'echo 1>&2'
         failOnStderr: true
         displayName: 'If above is partially succeeded, then fail'
-        condition: eq(variables['Agent.JobStatus'], 'SucceededWithIssues')
+        condition: eq(variables['Agent.JobStatus'], 'SucceededWithIssues')

build-system/nightly-builds.yaml

@@ -2,7 +2,7 @@
 # See https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema for reference
 
 pool:
-  vmImage: windows-2019
+  vmImage: windows-latest
   demands: Cmd
 
 trigger: none
@@ -19,8 +19,19 @@ variables:
   - group: nugetKeys #create this group with SECRET variables `nugetKey`
 
 steps:
-- task: BatchScript@1
-  displayName: 'FAKE Build'
-  inputs:
-    filename: build.cmd
-    arguments: 'Nuget nugetprerelease=dev nugetpublishurl=$(nightlyUrl) nugetkey=$(nightlyKey)'
+  - task: UseDotNet@2
+    displayName: 'Use .NET SDK from global.json'
+    inputs:
+      useGlobalJson: true
+
+  - powershell: ./build.ps1
+    displayName: 'Update Release Notes'
+    
+    # Pack with version suffix for nightly builds
+  - powershell: |
+      $timestamp = Get-Date -Format "yyyyMMddHHmmss"
+      dotnet pack -c Release -p:VersionSuffix=beta$timestamp -o $(Build.ArtifactStagingDirectory)/nuget
+    displayName: 'Create packages'
+
+  - script: dotnet nuget push "$(Build.ArtifactStagingDirectory)\nuget\*.nupkg" --api-key $(nightlyKey) --source $(nightlyUrl) --skip-duplicate
+    displayName: 'Publish to Nightly Feed'

build-system/pr-validation.yaml

@@ -1,5 +1,3 @@
-# Pull request validation for Windows against the `dev` and `master` branches
-# See https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema for reference
 trigger:
   branches:
     include:
@@ -11,29 +9,21 @@ pr:
   branches:
     include: [ dev, master ] # branch names which will trigger a build
 
-name: $(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r)
+name: $(SourceBranchName)_$(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r)
 
 jobs:
   - template: azure-pipeline.template.yaml
     parameters:
       name: 'windows_pr'
       displayName: 'Windows PR Validation'
       vmImage: 'windows-latest'
-      scriptFileName: build.cmd
-      scriptArgs: all
-      
-  - template: azure-pipeline.template.yaml
-    parameters:
-      name: 'linux_pr_net_core'
-      displayName: 'Linux PR Validation (netcoreapp3.1)'
-      vmImage: 'ubuntu-latest'
-      scriptFileName: ./build.sh
-      scriptArgs: runTestsNetCore
-      
+      outputDirectory: 'bin/nuget'
+      artifactName: 'nuget_pack-$(Build.BuildId)'
+
   - template: azure-pipeline.template.yaml
     parameters:
-      name: 'linux_pr_net_5'
-      displayName: 'Linux PR Validation (net5.0)'
+      name: 'linux_pr'
+      displayName: 'Linux PR Validation'
       vmImage: 'ubuntu-latest'
-      scriptFileName: ./build.sh
-      scriptArgs: runTestsNet
+      outputDirectory: 'bin/nuget'
+      artifactName: 'nuget_pack-$(Build.BuildId)'

build-system/windows-pr-validation.yaml

@@ -1,5 +1,3 @@
-# Pull request validation for Windows against the `dev` and `master` branches
-# See https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema for reference
 trigger:
   branches:
     include:
@@ -11,28 +9,21 @@ pr:
   branches:
     include: [ dev, master ] # branch names which will trigger a build
 
-name: $(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r)
+name: $(SourceBranchName)_$(Year:yyyy).$(Month).$(DayOfMonth)$(Rev:.r)
 
 jobs:
-- template: azure-pipeline.template.yaml
-  parameters:
-    name: Windows
-    vmImage: 'windows-latest'
-    scriptFileName: build.cmd
-    scriptArgs: all
+  - template: azure-pipeline.template.yaml
+    parameters:
+      name: 'windows_pr'
+      displayName: 'Windows PR Validation'
+      vmImage: 'windows-latest'
+      outputDirectory: 'bin/nuget'
+      artifactName: 'nuget_pack-$(Build.BuildId)'
 
-- template: azure-pipeline.template.yaml
-  parameters:
-    name: 'linux_pr_net_core'
-    displayName: 'Linux PR Validation (netcoreapp3.1)'
-    vmImage: 'ubuntu-latest'
-    scriptFileName: ./build.sh
-    scriptArgs: runTestsNetCore
-
-- template: azure-pipeline.template.yaml
-  parameters:
-    name: 'linux_pr_net_5'
-    displayName: 'Linux PR Validation (net5.0)'
-    vmImage: 'ubuntu-latest'
-    scriptFileName: ./build.sh
-    scriptArgs: runTestsNet
+  - template: azure-pipeline.template.yaml
+    parameters:
+      name: 'linux_pr'
+      displayName: 'Linux PR Validation'
+      vmImage: 'ubuntu-latest'
+      outputDirectory: 'bin/nuget'
+      artifactName: 'nuget_pack-$(Build.BuildId)'