Skip to content

Commit c800bf9

Browse files
abbyhu2000Ajay Gupta
authored andcommitted
[Vis Builder] Rename wizard on save modal and visualization table (opensearch-project#2645)
* Rename wizard on save modal and visualization table Change the wizard reference in save modal title, toggle and visualization table Signed-off-by: abbyhu2000 <[email protected]> * Save visualization on save modal, VisBuilder for chart type Signed-off-by: abbyhu2000 <[email protected]> * No experimental flag Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ajay Gupta <[email protected]>
1 parent eb67c49 commit c800bf9

File tree

6 files changed

+16
-5
lines changed

6 files changed

+16
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
3030
- [Multi DataSource] Address UX comments on Data source list and create page ([#2625](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2625))
3131
- [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id ([#2635](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2635))
3232
- [Vis Builder] Rename wizard to visBuilder in class name, type name and function name ([#2639](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2639))
33+
- [Vis Builder] Rename wizard on save modal and visualization table ([#2645](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2645))
3334

3435
### 🐛 Bug Fixes
3536

src/plugins/vis_builder/common/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ export const PLUGIN_ID = 'wizard';
77
export const PLUGIN_NAME = 'Wizard';
88
export const VISUALIZE_ID = 'visualize';
99
export const EDIT_PATH = '/edit';
10+
export const VIS_BUILDER_CHART_TYPE = 'VisBuilder';
1011

1112
export {
1213
VisBuilderSavedObjectAttributes,

src/plugins/vis_builder/public/application/utils/get_top_nav_config.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export const getTopNavConfig = (
9595
dispatch,
9696
services
9797
)}
98-
objectType={'wizard'}
98+
objectType={'visualization'}
9999
onClose={() => {}}
100100
originatingApp={originatingApp}
101101
getAppNameFromId={stateTransfer.getAppNameFromId}

src/plugins/vis_builder/public/plugin.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,13 @@ import {
2222
import { VisBuilderEmbeddableFactoryDefinition, VISBUILDER_EMBEDDABLE } from './embeddable';
2323
import visBuilderIconSecondaryFill from './assets/wizard_icon_secondary_fill.svg';
2424
import visBuilderIcon from './assets/wizard_icon.svg';
25-
import { EDIT_PATH, PLUGIN_ID, PLUGIN_NAME, VISBUILDER_SAVED_OBJECT } from '../common';
25+
import {
26+
EDIT_PATH,
27+
PLUGIN_ID,
28+
PLUGIN_NAME,
29+
VISBUILDER_SAVED_OBJECT,
30+
VIS_BUILDER_CHART_TYPE,
31+
} from '../common';
2632
import { TypeService } from './services/type_service';
2733
import { getPreloadedStore } from './application/utils/state_management';
2834
import {
@@ -134,7 +140,7 @@ export class VisBuilderPlugin
134140
savedObjectType: VISBUILDER_SAVED_OBJECT,
135141
stage: 'experimental',
136142
title: attributes?.title,
137-
typeTitle: PLUGIN_NAME,
143+
typeTitle: VIS_BUILDER_CHART_TYPE,
138144
updated_at: updatedAt,
139145
}),
140146
},

src/plugins/visualize/public/application/components/visualize_listing.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
.visListingTable__experimentalIcon {
1313
width: $euiSizeL;
14-
vertical-align: baseline;
14+
vertical-align: middle;
1515
padding: 0 $euiSizeS;
1616
margin-left: $euiSizeS;
1717
}

src/plugins/visualize/public/application/utils/get_table_columns.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,10 @@ const getBadge = (item: VisualizationListItem) => {
6060
return (
6161
<EuiBetaBadge
6262
className="visListingTable__experimentalIcon"
63-
label="E"
63+
label="Lab"
64+
size="s"
65+
color="subdued"
66+
iconType={'beaker'}
6467
title={i18n.translate('visualize.listing.experimentalTitle', {
6568
defaultMessage: 'Experimental',
6669
})}

0 commit comments

Comments
 (0)