Remove support for edge case where username is empty

Author: ajgarlag

src/Converter/UserConverter.php

@@ -10,20 +10,8 @@
 
 final class UserConverter implements UserConverterInterface
 {
-    public const DEFAULT_ANONYMOUS_USER_IDENTIFIER = 'anonymous';
-
-    /** @var non-empty-string */
-    private string $anonymousUserIdentifier;
-
-    /**
-     * @param non-empty-string $anonymousUserIdentifier
-     */
-    public function __construct(string $anonymousUserIdentifier = self::DEFAULT_ANONYMOUS_USER_IDENTIFIER)
-    {
-        $this->anonymousUserIdentifier = $anonymousUserIdentifier;
-    }
-
     /**
+     * @psalm-suppress ArgumentTypeCoercion
      * @psalm-suppress DeprecatedMethod
      * @psalm-suppress UndefinedInterfaceMethod
      */
@@ -32,9 +20,6 @@ public function toLeague(UserInterface $user): UserEntityInterface
         $userEntity = new User();
 
         $identifier = method_exists($user, 'getUserIdentifier') ? $user->getUserIdentifier() : $user->getUsername();
-        if ('' === $identifier) {
-            $identifier = $this->anonymousUserIdentifier;
-        }
 
         $userEntity->setIdentifier($identifier);
 

src/DependencyInjection/Configuration.php

@@ -5,7 +5,6 @@
 namespace League\Bundle\OAuth2ServerBundle\DependencyInjection;
 
 use Defuse\Crypto\Key;
-use League\Bundle\OAuth2ServerBundle\Converter\UserConverter;
 use League\Bundle\OAuth2ServerBundle\Model\AbstractClient;
 use League\Bundle\OAuth2ServerBundle\Model\Client;
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
@@ -32,11 +31,6 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->defaultValue('ROLE_OAUTH2_')
                     ->cannotBeEmpty()
                 ->end()
-                ->scalarNode('anonymous_user_identifier')
-                    ->info('Set a default user identifier for anonymous users')
-                    ->defaultValue(UserConverter::DEFAULT_ANONYMOUS_USER_IDENTIFIER)
-                    ->cannotBeEmpty()
-                ->end()
             ->end();
 
         return $treeBuilder;

src/DependencyInjection/LeagueOAuth2ServerExtension.php

@@ -8,7 +8,6 @@
 use League\Bundle\OAuth2ServerBundle\AuthorizationServer\GrantTypeInterface;
 use League\Bundle\OAuth2ServerBundle\Command\CreateClientCommand;
 use League\Bundle\OAuth2ServerBundle\Command\GenerateKeyPairCommand;
-use League\Bundle\OAuth2ServerBundle\Converter\UserConverter;
 use League\Bundle\OAuth2ServerBundle\DBAL\Type\Grant as GrantType;
 use League\Bundle\OAuth2ServerBundle\DBAL\Type\RedirectUri as RedirectUriType;
 use League\Bundle\OAuth2ServerBundle\DBAL\Type\Scope as ScopeType;
@@ -69,9 +68,6 @@ public function load(array $configs, ContainerBuilder $container)
         $container->findDefinition(OAuth2Authenticator::class)
             ->setArgument(3, $config['role_prefix']);
 
-        $container->findDefinition(UserConverter::class)
-            ->setArgument(0, $config['anonymous_user_identifier']);
-
         $container->registerForAutoconfiguration(GrantTypeInterface::class)
             ->addTag('league.oauth2_server.authorization_server.grant');