-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Folding for comments and different modes #5533
Conversation
# Conflicts: # src/mode/folding/javascript_test.js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
+ Coverage 86.67% 86.76% +0.08%
==========================================
Files 593 594 +1
Lines 42940 42977 +37
Branches 7126 7126
==========================================
+ Hits 37218 37287 +69
+ Misses 5722 5690 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hey @mkslanc , the change looks good to me! Could you please resolve the merge conflict. |
# Conflicts: # src/mode/_test/tokens_flix.json
hey @akoreman ! This should make it |
Issue #, if available: #5521
Description of changes:
getCommentFoldRange
.getFoldRange
won't return the next tag after a comment)./**/
case.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: