Skip to content

Commit e14902e

Browse files
authored
fix: Fix vite build and webpack warning (#5192)
* rename css.js files to not confuse vite bundler * add default exports to keys * fix typing * remove undecidable require call
1 parent 5eb78ad commit e14902e

File tree

96 files changed

+69
-65
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

96 files changed

+69
-65
lines changed

ace.d.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,7 @@ export namespace Ace {
884884
setStyle(style: string): void;
885885
unsetStyle(style: string): void;
886886
getFontSize(): string;
887-
setFontSize(size: number): void;
887+
setFontSize(size: number|string): void;
888888
focus(): void;
889889
isFocused(): boolean;
890890
blur(): void;
@@ -1097,6 +1097,9 @@ export const EditSession: {
10971097
export const UndoManager: {
10981098
new(): Ace.UndoManager;
10991099
};
1100+
export const Editor: {
1101+
new(): Ace.Editor;
1102+
};
11001103
export const Range: {
11011104
new(startRow: number, startColumn: number, endRow: number, endColumn: number): Ace.Range;
11021105
fromPoints(start: Ace.Point, end: Ace.Point): Ace.Range;

src/config.js

+16-7
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,26 @@ exports.setModuleUrl = function(name, subst) {
7777
var loader = function(moduleName, cb) {
7878
if (moduleName === "ace/theme/textmate" || moduleName === "./theme/textmate")
7979
return cb(null, require("./theme/textmate"));
80-
return console.error("loader is not configured");
80+
if (typeof module.require == "function") {
81+
// backwards compatibility for node
82+
try {
83+
var req = "require";
84+
return cb(null, module[req](moduleName));
85+
} catch (e) {
86+
}
87+
}
88+
if (customLoader)
89+
return customLoader(moduleName, cb);
90+
console.error("loader is not configured");
8191
};
82-
92+
var customLoader;
8393
exports.setLoader = function(cb) {
84-
loader = cb;
94+
customLoader = cb;
8595
};
8696

8797
exports.dynamicModules = Object.create(null);
8898
exports.$loading = {};
99+
exports.$loaded = {};
89100
exports.loadModule = function(moduleName, onLoad) {
90101
var module, moduleType;
91102
if (Array.isArray(moduleName)) {
@@ -105,6 +116,7 @@ exports.loadModule = function(moduleName, onLoad) {
105116

106117
var afterLoad = function() {
107118
loader(moduleName, function(err, module) {
119+
if (module) exports.$loaded[moduleName] = module;
108120
exports._emit("load.module", {name: moduleName, module: module});
109121
var listeners = exports.$loading[moduleName];
110122
exports.$loading[moduleName] = null;
@@ -130,10 +142,7 @@ exports.loadModule = function(moduleName, onLoad) {
130142
}
131143
});
132144
} else {
133-
try {
134-
module = require(moduleName);
135-
} catch (e) {}
136-
load(module);
145+
load(module || exports.$loaded[moduleName]);
137146
}
138147
};
139148

File renamed without changes.

src/ext/textarea.js

-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
var event = require("../lib/event");
44
var UA = require("../lib/useragent");
5-
var net = require("../lib/net");
65
var ace = require("../ace");
76

87
module.exports = exports = ace;
@@ -231,16 +230,7 @@ exports.transformTextarea = function(element, options) {
231230
return editor;
232231
};
233232

234-
function load(url, module, callback) {
235-
net.loadScript(url, function() {
236-
require([module], callback);
237-
});
238-
}
239-
240233
function setupApi(editor, editorDiv, settingDiv, ace, options) {
241-
var session = editor.getSession();
242-
var renderer = editor.renderer;
243-
244234
function toBool(value) {
245235
return value === "true" || value == true;
246236
}

src/lib/keys.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ var Keys = (function() {
137137

138138
(function() {
139139
var mods = ["cmd", "ctrl", "alt", "shift"];
140-
for (var i = Math.pow(2, mods.length); i--;) {
140+
for (var i = Math.pow(2, mods.length); i--;) {
141141
ret.KEY_MODS[i] = mods.filter(function(x) {
142142
return i & ret.KEY_MODS[x];
143143
}).join("-") + "-";
@@ -151,6 +151,8 @@ var Keys = (function() {
151151
})();
152152
oop.mixin(exports, Keys);
153153

154+
exports.default = exports;
155+
154156
exports.keyCodeToString = function(keyCode) {
155157
// Language-switching keystroke in Chrome/Linux emits keyCode 0.
156158
var keyString = Keys[keyCode];
File renamed without changes.

src/theme/ambiance.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-ambiance";
3-
exports.cssText = require("./ambiance.css");
3+
exports.cssText = require("./ambiance-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/chaos.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-chaos";
3-
exports.cssText = require("./chaos.css");
3+
exports.cssText = require("./chaos-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/chrome.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-chrome";
3-
exports.cssText = require("./chrome.css");
3+
exports.cssText = require("./chrome-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/cloud9_day.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
exports.isDark = false;
44
exports.cssClass = "ace-cloud9-day";
5-
exports.cssText = require("./cloud9_day.css");
5+
exports.cssText = require("./cloud9_day-css");
66

77
var dom = require("../lib/dom");
88
dom.importCssString(exports.cssText, exports.cssClass);
File renamed without changes.

src/theme/cloud9_night.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-cloud9-night";
3-
exports.cssText = require("./cloud9_night.css");
3+
exports.cssText = require("./cloud9_night-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass);

src/theme/cloud9_night_low_color.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-cloud9-night-low-color";
3-
exports.cssText = require("./cloud9_night_low_color.css");
3+
exports.cssText = require("./cloud9_night_low_color-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass);
File renamed without changes.

src/theme/clouds.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-clouds";
3-
exports.cssText = require("./clouds.css");
3+
exports.cssText = require("./clouds-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/clouds_midnight.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-clouds-midnight";
3-
exports.cssText = require("./clouds_midnight.css");
3+
exports.cssText = require("./clouds_midnight-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/cobalt.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-cobalt";
3-
exports.cssText = require("./cobalt.css");
3+
exports.cssText = require("./cobalt-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/crimson_editor.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
exports.isDark = false;
2-
exports.cssText = require("./crimson_editor.css");
2+
exports.cssText = require("./crimson_editor-css");
33

44
exports.cssClass = "ace-crimson-editor";
55

File renamed without changes.

src/theme/dawn.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-dawn";
3-
exports.cssText = require("./dawn.css");
3+
exports.cssText = require("./dawn-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/dracula.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-dracula";
3-
exports.cssText = require("./dracula.css");
3+
exports.cssText = require("./dracula-css");
44
exports.$selectionColorConflict = true;
55

66
var dom = require("../lib/dom");
File renamed without changes.

src/theme/dreamweaver.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-dreamweaver";
3-
exports.cssText = require("./dreamweaver.css");
3+
exports.cssText = require("./dreamweaver-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/eclipse.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"use strict";
22

33
exports.isDark = false;
4-
exports.cssText = require("./eclipse.css");
4+
exports.cssText = require("./eclipse-css");
55

66
exports.cssClass = "ace-eclipse";
77

File renamed without changes.

src/theme/github.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-github";
3-
exports.cssText = require("./github.css");
3+
exports.cssText = require("./github-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/github_dark.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-github-dark";
3-
exports.cssText = require("./github_dark.css");
3+
exports.cssText = require("./github_dark-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/gob.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-gob";
3-
exports.cssText = require("./gob.css");
3+
exports.cssText = require("./gob-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/gruvbox.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-gruvbox";
3-
exports.cssText = require("./gruvbox.css");
3+
exports.cssText = require("./gruvbox-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/gruvbox_dark_hard.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-gruvbox-dark-hard";
3-
exports.cssText = require("./gruvbox_dark_hard.css");
3+
exports.cssText = require("./gruvbox_dark_hard-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass);
File renamed without changes.

src/theme/gruvbox_light_hard.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-gruvbox-light-hard";
3-
exports.cssText = require("./gruvbox_light_hard.css");
3+
exports.cssText = require("./gruvbox_light_hard-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass);
File renamed without changes.

src/theme/idle_fingers.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-idle-fingers";
3-
exports.cssText = require("./idle_fingers.css");
3+
exports.cssText = require("./idle_fingers-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/iplastic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-iplastic";
3-
exports.cssText = require("./iplastic.css");
3+
exports.cssText = require("./iplastic-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/katzenmilch.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-katzenmilch";
3-
exports.cssText = require("./katzenmilch.css");
3+
exports.cssText = require("./katzenmilch-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/kr_theme.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-kr-theme";
3-
exports.cssText = require("./kr_theme.css");
3+
exports.cssText = require("./kr_theme-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/kuroir.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-kuroir";
3-
exports.cssText = require("./kuroir.css");
3+
exports.cssText = require("./kuroir-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/merbivore.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-merbivore";
3-
exports.cssText = require("./merbivore.css");
3+
exports.cssText = require("./merbivore-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/merbivore_soft.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-merbivore-soft";
3-
exports.cssText = require("./merbivore_soft.css");
3+
exports.cssText = require("./merbivore_soft-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/mono_industrial.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-mono-industrial";
3-
exports.cssText = require("./mono_industrial.css");
3+
exports.cssText = require("./mono_industrial-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/monokai.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-monokai";
3-
exports.cssText = require("./monokai.css");
3+
exports.cssText = require("./monokai-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/nord_dark.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-nord-dark";
3-
exports.cssText = require("./nord_dark.css");
3+
exports.cssText = require("./nord_dark-css");
44
exports.$selectionColorConflict = true;
55

66
var dom = require("../lib/dom");
File renamed without changes.

src/theme/one_dark.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-one-dark";
3-
exports.cssText = require("./one_dark.css");
3+
exports.cssText = require("./one_dark-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/pastel_on_dark.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-pastel-on-dark";
3-
exports.cssText = require("./pastel_on_dark.css");
3+
exports.cssText = require("./pastel_on_dark-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/solarized_dark.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = true;
22
exports.cssClass = "ace-solarized-dark";
3-
exports.cssText = require("./solarized_dark.css");
3+
exports.cssText = require("./solarized_dark-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/solarized_light.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-solarized-light";
3-
exports.cssText = require("./solarized_light.css");
3+
exports.cssText = require("./solarized_light-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

src/theme/sqlserver.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
exports.isDark = false;
22
exports.cssClass = "ace-sqlserver";
3-
exports.cssText = require("./sqlserver.css");
3+
exports.cssText = require("./sqlserver-css");
44

55
var dom = require("../lib/dom");
66
dom.importCssString(exports.cssText, exports.cssClass, false);
File renamed without changes.

0 commit comments

Comments
 (0)